Skip to content

Enable ruff RUF100 rule #11337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions audio_filters/butterworth_filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def make_lowpass(
frequency: int,
samplerate: int,
q_factor: float = 1 / sqrt(2), # noqa: B008
q_factor: float = 1 / sqrt(2),
) -> IIRFilter:
"""
Creates a low-pass filter
Expand Down Expand Up @@ -43,7 +43,7 @@ def make_lowpass(
def make_highpass(
frequency: int,
samplerate: int,
q_factor: float = 1 / sqrt(2), # noqa: B008
q_factor: float = 1 / sqrt(2),
) -> IIRFilter:
"""
Creates a high-pass filter
Expand Down Expand Up @@ -73,7 +73,7 @@ def make_highpass(
def make_bandpass(
frequency: int,
samplerate: int,
q_factor: float = 1 / sqrt(2), # noqa: B008
q_factor: float = 1 / sqrt(2),
) -> IIRFilter:
"""
Creates a band-pass filter
Expand Down Expand Up @@ -104,7 +104,7 @@ def make_bandpass(
def make_allpass(
frequency: int,
samplerate: int,
q_factor: float = 1 / sqrt(2), # noqa: B008
q_factor: float = 1 / sqrt(2),
) -> IIRFilter:
"""
Creates an all-pass filter
Expand Down Expand Up @@ -132,7 +132,7 @@ def make_peak(
frequency: int,
samplerate: int,
gain_db: float,
q_factor: float = 1 / sqrt(2), # noqa: B008
q_factor: float = 1 / sqrt(2),
) -> IIRFilter:
"""
Creates a peak filter
Expand Down Expand Up @@ -164,7 +164,7 @@ def make_lowshelf(
frequency: int,
samplerate: int,
gain_db: float,
q_factor: float = 1 / sqrt(2), # noqa: B008
q_factor: float = 1 / sqrt(2),
) -> IIRFilter:
"""
Creates a low-shelf filter
Expand Down Expand Up @@ -201,7 +201,7 @@ def make_highshelf(
frequency: int,
samplerate: int,
gain_db: float,
q_factor: float = 1 / sqrt(2), # noqa: B008
q_factor: float = 1 / sqrt(2),
) -> IIRFilter:
"""
Creates a high-shelf filter
Expand Down
2 changes: 1 addition & 1 deletion data_structures/binary_tree/basic_binary_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def depth(self) -> int:
"""
return self._depth(self.root)

def _depth(self, node: Node | None) -> int: # noqa: UP007
def _depth(self, node: Node | None) -> int:
if not node:
return 0
return 1 + max(self._depth(node.left), self._depth(node.right))
Expand Down
2 changes: 1 addition & 1 deletion data_structures/binary_tree/non_recursive_segment_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def update(self, p: int, v: T) -> None:
p = p // 2
self.st[p] = self.fn(self.st[p * 2], self.st[p * 2 + 1])

def query(self, l: int, r: int) -> T | None: # noqa: E741
def query(self, l: int, r: int) -> T | None:
"""
Get range query value in log(N) time
:param l: left element index
Expand Down
2 changes: 1 addition & 1 deletion data_structures/binary_tree/red_black_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def _insert_repair(self) -> None:
self.grandparent.color = 1
self.grandparent._insert_repair()

def remove(self, label: int) -> RedBlackTree: # noqa: PLR0912
def remove(self, label: int) -> RedBlackTree:
"""Remove label from this tree."""
if self.label == label:
if self.left and self.right:
Expand Down
6 changes: 3 additions & 3 deletions data_structures/binary_tree/segment_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def right(self, idx):
"""
return idx * 2 + 1

def build(self, idx, l, r): # noqa: E741
def build(self, idx, l, r):
if l == r:
self.st[idx] = self.A[l]
else:
Expand All @@ -56,7 +56,7 @@ def update(self, a, b, val):
"""
return self.update_recursive(1, 0, self.N - 1, a - 1, b - 1, val)

def update_recursive(self, idx, l, r, a, b, val): # noqa: E741
def update_recursive(self, idx, l, r, a, b, val):
"""
update(1, 1, N, a, b, v) for update val v to [a,b]
"""
Expand All @@ -83,7 +83,7 @@ def query(self, a, b):
"""
return self.query_recursive(1, 0, self.N - 1, a - 1, b - 1)

def query_recursive(self, idx, l, r, a, b): # noqa: E741
def query_recursive(self, idx, l, r, a, b):
"""
query(1, 1, N, a, b) for query max of [a,b]
"""
Expand Down
2 changes: 1 addition & 1 deletion data_structures/heap/min_heap.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def build_heap(self, array):
# this is min-heapify method
def sift_down(self, idx, array):
while True:
l = self.get_left_child_idx(idx) # noqa: E741
l = self.get_left_child_idx(idx)
r = self.get_right_child_idx(idx)

smallest = idx
Expand Down
2 changes: 1 addition & 1 deletion dynamic_programming/longest_common_subsequence.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def longest_common_subsequence(x: str, y: str):
n = len(y)

# declaring the array for storing the dp values
l = [[0] * (n + 1) for _ in range(m + 1)] # noqa: E741
l = [[0] * (n + 1) for _ in range(m + 1)]

for i in range(1, m + 1):
for j in range(1, n + 1):
Expand Down
4 changes: 2 additions & 2 deletions dynamic_programming/longest_increasing_subsequence_o_nlogn.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
from __future__ import annotations


def ceil_index(v, l, r, key): # noqa: E741
def ceil_index(v, l, r, key):
while r - l > 1:
m = (l + r) // 2
if v[m] >= key:
r = m
else:
l = m # noqa: E741
l = m
return r


Expand Down
2 changes: 1 addition & 1 deletion graphs/articulation_points.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Finding Articulation Points in Undirected Graph
def compute_ap(l): # noqa: E741
def compute_ap(l):
n = len(l)
out_edge_count = 0
low = [0] * n
Expand Down
2 changes: 1 addition & 1 deletion graphs/dinic.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def depth_first_search(self, vertex, sink, flow):
# Here we calculate the flow that reaches the sink
def max_flow(self, source, sink):
flow, self.q[0] = 0, source
for l in range(31): # noqa: E741 l = 30 maybe faster for random data
for l in range(31): # l = 30 maybe faster for random data
while True:
self.lvl, self.ptr = [0] * len(self.q), [0] * len(self.q)
qi, qe, self.lvl[source] = 0, 1, 1
Expand Down
4 changes: 2 additions & 2 deletions other/sdes.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ def function(expansion, s0, s1, key, message):
right = message[4:]
temp = apply_table(right, expansion)
temp = xor(temp, key)
l = apply_sbox(s0, temp[:4]) # noqa: E741
l = apply_sbox(s0, temp[:4])
r = apply_sbox(s1, temp[4:])
l = "0" * (2 - len(l)) + l # noqa: E741
l = "0" * (2 - len(l)) + l
r = "0" * (2 - len(r)) + r
temp = apply_table(l + r, p4_table)
temp = xor(left, temp)
Expand Down
2 changes: 1 addition & 1 deletion project_euler/problem_011/sol2.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def solution():
70600674
"""
with open(os.path.dirname(__file__) + "/grid.txt") as f:
l = [] # noqa: E741
l = []
for _ in range(20):
l.append([int(x) for x in f.readline().split()])

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ lint.ignore = [ # `ruff rule S101` for a description of that rule
"PT011", # `pytest.raises(Exception)` is too broad, set the `match` parameter or use a more specific exception
"PT018", # Assertion should be broken down into multiple parts
"RUF00", # Ambiguous unicode character and other rules
"RUF100", # Unused `noqa` directive -- FIX ME
"S101", # Use of `assert` detected -- DO NOT FIX
"S105", # Possible hardcoded password: 'password'
"S113", # Probable use of requests call without timeout -- FIX ME
Expand Down
2 changes: 1 addition & 1 deletion strings/manacher.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def palindromic_string(input_string: str) -> str:
# does this string is ending after the previously explored end (that is r) ?
# if yes the update the new r to the last index of this
if j + k - 1 > r:
l = j - k + 1 # noqa: E741
l = j - k + 1
r = j + k - 1

# update max_length and start position
Expand Down