-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Seperate client and server of FTP #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TravisCI is hanging on pytest probably due to the server running an infinite loop, should we add it to the ignore in the pytest command, or should I make it so it only accepts one connection? @cclauss
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please close the server after one transfer but put comments in the code that describes that carefully. For extra credit, add a ONE_CONNECTION_ONLY = True constant to make the code easier to reconfigure.
Also please remove this line and make sure the Travis test passes. |
(this is a seperate issue, but the actual FTP protocol does not operate as it does in |
One undefined name 's' https://travis-ci.org/TheAlgorithms/Python/jobs/568640601#L564 |
It seems to be hanging our pytest discovery process. Perhaps put the code under an ìf name == "main":` block so that is not executed each time that pytest imports the file. |
the entirity of |
what should we do about this? |
Landed!! Well done! |
* added sample file to transfer * split client and server into separate files * client and server now work in python2 * server works on python3 * client works on python3 * allow configurable ONE_CONNECTION_ONLY for testing server * allow testing of ftp server + client * use f-strings * removed single letter vars * fixed bad quote marks * clearer file handler names * 'with open() as' syntax * unicode and emojis in the test data * s -> sock * consistent comment spacing * remove closing formalities * swap in and out_file * f-string * if __name__ == '__main__':
fixes issues found in PR#1044 @cclauss