-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
Zeller's Congruence Algorithm #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed unused import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great piece of work. I approve it in its current state.
Please consider adding one or more tests to compare zeller()'s results against the Python standard library results:
>>> from datetime import datetime
>>> f"{datetime(2019, 8, 4):%A}"
Just FYI: Dates are a pain in all programming languages but these two libraries help...
https://arrow.readthedocs.io
https://www.kennethreitz.org/essays/introducing-maya-datetimes-for-humans
Updated to add suggestions, and to fix the issue with TravisCI and the Dict annotation. |
* doctest updates * remove unused math import * cleanup (suggestions) * cleanup - Dict fix (TravisCI error)
Let me know of any other improvements I can make. 👍