Implement ruling hash to appropriate complexity of Rabin Karp #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mahbubcseju
commented
Jul 24, 2019
mahbubcseju
commented
- Previous solution is based on the hash function of python.
- Implemented ruling hash to get the appropriate complexity of rabin karp.
* Implemented the way of finding nth fibonacci. * Complexity is about O(log(n)*8)
- Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request
- Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request
- Previous solution is based on the hash function of python. - Implemented ruling hash to get the appropriate complexity of rabin karp.
cclauss
requested changes
Jul 24, 2019
cclauss
changed the title
|
Could you please add a test containing Unicode patterns? |
- Previous solution is based on the hash function of python. - Implemented ruling hash to get the appropriate complexity of rabin karp.
Actually I dont know about Unicode pattern testing. Trying to learn about it |
|
Pytest did not find our automated tests. :-( Can you please add a docetest by changing the code to read: def test_rabin_karp():
"""
>>> test_rabin_karp()
Success.
"""
[ then the body of the function as it is and then at the end of the function... ]
print("Success.") |
|
You should be able to test this doctest locally with: |
Added unit pattern testing
Yes , Done ! |
cclauss
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
Nice. That works... https://travis-ci.org/TheAlgorithms/Python/builds/562971505#L670
Are we ready to merge? Or did you want to add the Unicode test(s) first?
|
Yes, please merge. |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…orithms#1066) * Added matrix exponentiation approach for finding fibonacci number. * Implemented the way of finding nth fibonacci. * Complexity is about O(log(n)*8) * Updated the matrix exponentiation approach of finding nth fibonacci. - Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request * Updated the matrix exponentiation approach of finding nth fibonacci. - Removed some extra spaces - Added the complexity of bruteforce algorithm - Removed unused function called zerro() - Added some docktest based on request * Updated Rabin Karp algorithm. - Previous solution is based on the hash function of python. - Implemented ruling hash to get the appropriate complexity of rabin karp. * Updated Rabin Karp algorithm. - Previous solution is based on the hash function of python. - Implemented ruling hash to get the appropriate complexity of rabin karp. * Implemented ruling hash to appropriate complexity of Rabin Karp Added unit pattern testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.