Skip to content

Weight Conversion #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnubhavSolanki opened this issue Nov 13, 2020 · 10 comments
Closed

Weight Conversion #3888

AnubhavSolanki opened this issue Nov 13, 2020 · 10 comments

Comments

@AnubhavSolanki
Copy link
Contributor

As there is no weight conversion algorithm till now so I like to add one.

@erdum
Copy link
Contributor

erdum commented Nov 23, 2020

Yes i would be very nice to have, i will also contribute in

@amaank404
Copy link
Contributor

any progress? or this might end up as stale issue

@AnubhavSolanki
Copy link
Contributor Author

i have created it but it's my first open source contribution i don't how to do it
Can you guide me?

@AnubhavSolanki
Copy link
Contributor Author

@xcodz-dot @erdum

@amaank404
Copy link
Contributor

  • OK, First of all make a fork of this repo
  • clone it locally
  • make changes to local copy (add files)
  • run these commands in order:
    • pip install pre-commit
    • pre-commit run -a It might show you it failed, but do not worry (It did not actually fail)
  • commit and push the changes to your fork repo from local copy
  • go to pull request sections of your fork
  • click on a new PR button
  • start your PR

@amaank404
Copy link
Contributor

You can do google searches for more info (that is the way how i learnt github)

@AnubhavSolanki
Copy link
Contributor Author

can u check my PR @xcodz-dot
#3964
I don't know what's wrong with it?

@erdum
Copy link
Contributor

erdum commented Nov 26, 2020

i also recently made my first contribution
please make sure your code is neat because this is most important

@amaank404
Copy link
Contributor

Hello, there is a very simple command set which is:

  • pip install pre-commit
  • pre-commit run -a at root of local copy of repo

This doesn't require much hard work to format codes

@dhruvmanila
Copy link
Member

This issue got closed with #3964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants