Skip to content

Formatting issues not getting caught in TravisCI #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onlinejudge95 opened this issue May 30, 2020 · 1 comment
Closed

Formatting issues not getting caught in TravisCI #2050

onlinejudge95 opened this issue May 30, 2020 · 1 comment
Labels

Comments

@onlinejudge95
Copy link
Collaborator

It has come into the observation that files that are not black compliant are still passing the Travis CI build. Due to which our master has failing checks. Can we do something about it?

Reference #2041

@cclauss
Copy link
Member

cclauss commented May 31, 2020

See the second commit on #2051

The GitHub Action autoblack (not Travis CI) autoformats our code. It only runs when a maintainer (with the commit bit) creates a PR. This approach gives us eventual compliance with psf/black without having to teach every first-time contributor what psf/black is and how to use it.

@cclauss cclauss closed this as completed May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants