Skip to content

Head and temp names should change #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tirthajyoti opened this issue Oct 18, 2019 · 1 comment · Fixed by #1403
Closed

Head and temp names should change #1397

tirthajyoti opened this issue Oct 18, 2019 · 1 comment · Fixed by #1403

Comments

@tirthajyoti
Copy link

Hi,

In your Linked List implementation, I think temp is wrongly spelled as tamp. The code works but for readability purpose all tamp should be replaced by temp.

Also, I find it strange to name the head with a capital Head. Generally, capitalization in Python is saved for Class names, not class attributes or methods. If you think the code should be more Pythonic, please consider changing all Head to head in the class attributes for Linked List.
@cclauss
Copy link
Member

cclauss commented Oct 19, 2019

Agreed. Can you please submit a pull request that fixes these issues and adds doctests?

@ManuMBhat ManuMBhat mentioned this issue Oct 19, 2019
Merged
cclauss pushed a commit that referenced this issue Oct 19, 2019
@ManuMBhat @cclauss
Issue #1397 (#1403)
cd10c94
stokhos pushed a commit to stokhos/Python that referenced this issue Jan 3, 2021
@ManuMBhat @stokhos
Issue TheAlgorithms#1397 (TheAlgorithms#1403)
66d153e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Readability improvements to singly_linked_list.py
2 participants
@cclauss @tirthajyoti