-
-
Notifications
You must be signed in to change notification settings - Fork 46.8k
file_transfer_protocol doesn't actually implement FTP #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What would be a better, less misleading title for these files? |
send_data.py? |
send_file.py and receive_file.py ? Please consider submitting a PR. |
sure, |
Should the directory name also be changed? |
I wouldn't because I think that an actual implementation of FTP would make more sense with this simple sending and receiving a file over sockets. (I currently do not have the time to implement the actual FTP protocol, but I believe it would be valuable? Unless it is out of scope for the repo?) |
There are already open source implémentations of ftp. Why not just rename the directory file_transfer and it can contain just a few simple examples. |
sure, does this look good? https://github.com/dlsyj/ftp |
We do not need a full implementation of ftp in this repo. Just some simple implementations of how to transfer a file from one machine to another. |
It simply sends the contents of a single file over a TCP socket, with no support for browsing directories, or authentication. While this is a good demo of how to setup and use TCP sockets in Python, it is not really an implementation of FTP.
The text was updated successfully, but these errors were encountered: