Skip to content

file_transfer_protocol doesn't actually implement FTP #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexDvorak opened this issue Aug 7, 2019 · 9 comments · Fixed by #1116
Closed

file_transfer_protocol doesn't actually implement FTP #1113

AlexDvorak opened this issue Aug 7, 2019 · 9 comments · Fixed by #1116

Comments

@AlexDvorak
Copy link
Contributor

It simply sends the contents of a single file over a TCP socket, with no support for browsing directories, or authentication. While this is a good demo of how to setup and use TCP sockets in Python, it is not really an implementation of FTP.

@cclauss
Copy link
Member

cclauss commented Aug 7, 2019

What would be a better, less misleading title for these files?

@AlexDvorak
Copy link
Contributor Author

send_data.py?

@cclauss
Copy link
Member

cclauss commented Aug 7, 2019

send_file.py and receive_file.py ?
send_a_file.py and receive_a_file.py ?

Please consider submitting a PR.

@AlexDvorak
Copy link
Contributor Author

sure, send_file.py and receive_file.py sounds good

@cclauss
Copy link
Member

cclauss commented Aug 7, 2019

Should the directory name also be changed?

@AlexDvorak
Copy link
Contributor Author

AlexDvorak commented Aug 7, 2019

I wouldn't because I think that an actual implementation of FTP would make more sense with this simple sending and receiving a file over sockets. (I currently do not have the time to implement the actual FTP protocol, but I believe it would be valuable? Unless it is out of scope for the repo?)

@cclauss
Copy link
Member

cclauss commented Aug 7, 2019

There are already open source implémentations of ftp. Why not just rename the directory file_transfer and it can contain just a few simple examples.

@AlexDvorak
Copy link
Contributor Author

sure, does this look good? https://github.com/dlsyj/ftp

@cclauss
Copy link
Member

cclauss commented Aug 7, 2019

We do not need a full implementation of ftp in this repo. Just some simple implementations of how to transfer a file from one machine to another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants