Skip to content

Upgrade max char #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
May 2, 2022
Merged

Upgrade max char #983

merged 43 commits into from
May 2, 2022

Conversation

fahimfaisaal
Copy link
Contributor

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Replace the recent algorithm.
  • Replace the test case.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair I only see a minor, questionable improvement (the customizable character filter) and a bunch of extraneous syntactic sugar.

@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Apr 30, 2022
@appgurueu appgurueu added the changes required This pull request needs changes label Apr 30, 2022
@stale stale bot removed the stale Closed due to age label Apr 30, 2022
@fahimfaisaal
Copy link
Contributor Author

I feel now it's prefect

@raklaptudirm raklaptudirm requested a review from appgurueu May 1, 2022 08:50
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the raised issues

@raklaptudirm raklaptudirm added feature Adds a new feature Reviewed and removed changes required This pull request needs changes labels May 2, 2022
@raklaptudirm raklaptudirm merged commit 2806253 into TheAlgorithms:master May 2, 2022
@fahimfaisaal fahimfaisaal deleted the upgrade-MaxChar branch May 7, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants