merge: Upgrade Lower function #894

fahimfaisaal · 2022-02-18T15:20:46Z

Welcome to JavaScript community

Optimize the Lower.js algo via using regex and String.prototype.replace method.
Update some js doc.
Add four new test cases.

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new JavaScript files are placed inside an existing directory.
All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

ignore the useless traverse in best case via regex and String.prototype.replace

String/Lower.js

fahimfaisaal · 2022-02-19T11:33:26Z

Done

fahimfaisaal added 4 commits February 18, 2022 21:08

docs: update the js doc

1d32c02

pref: Optimize algo via regex

b8d0164

ignore the useless traverse in best case via regex and String.prototype.replace

test: add some new test cases

2d70c7b

fix: styled with standard

a46116d

fahimfaisaal requested a review from raklaptudirm as a code owner February 18, 2022 15:20

raklaptudirm requested changes Feb 19, 2022

View reviewed changes

String/Lower.js Outdated Show resolved Hide resolved

refactor: remove useless variable

131556b

raklaptudirm approved these changes Feb 19, 2022

View reviewed changes

raklaptudirm added algorithm Adds or improves an algorithm feature Adds a new feature labels Feb 19, 2022

raklaptudirm merged commit 041918d into TheAlgorithms:master Feb 19, 2022

fahimfaisaal deleted the upgrade-lower branch March 29, 2022 07:22