Skip to content

added Problem 25 to Euler #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 21, 2021
Merged

added Problem 25 to Euler #793

merged 13 commits into from
Oct 21, 2021

Conversation

byt3h3ad
Copy link
Contributor

@byt3h3ad byt3h3ad commented Oct 16, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2021

This pull request introduces 1 alert when merging f97bdc3 into 5f601fa - view on LGTM.com

new alerts:

  • 1 for Missing variable declaration

@raklaptudirm
Copy link
Member

Please fix the raised alerts.

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compute the fibonacci numbers and check their digits together in one function, so as not to redo all the calculations every iteration

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 16, 2021
@byt3h3ad byt3h3ad requested a review from raklaptudirm October 17, 2021 13:58
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some jest tests.

byt3h3ad and others added 2 commits October 21, 2021 17:53
Co-authored-by: Rak Laptudirm <raklaptudirm@gmail.com>
@raklaptudirm
Copy link
Member

@cclauss Could you determine why standard.js is saying "BigInt is not defined"?

@cclauss
Copy link
Member

cclauss commented Oct 21, 2021

I do not do JavaScript.

@raklaptudirm
Copy link
Member

@byt3h3ad One sec we need to update standard.js.

@byt3h3ad
Copy link
Contributor Author

@byt3h3ad One sec we need to update standard.js.

yeah, no problem!

@raklaptudirm
Copy link
Member

raklaptudirm commented Oct 21, 2021

@byt3h3ad Please update this branch to show the latest code updates in the repository. That should fix the issue.

@byt3h3ad
Copy link
Contributor Author

okay done @raklaptudirm

@raklaptudirm raklaptudirm removed the changes required This pull request needs changes label Oct 21, 2021
@raklaptudirm raklaptudirm merged commit e567797 into TheAlgorithms:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants