Skip to content

Added QuickSelect Algorithm #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

achudinovskyh
Copy link
Contributor

#14 I've added Quick Select algorithm

  • Add an algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@marsonya
Copy link
Contributor

Hey @achudinovskyh, this is great work. There's just one thing missing.
The Doctests. Kindly see CONTRIBUTING.md for details.

You may also refer this file.

@marsonya marsonya self-requested a review December 21, 2020 06:05
@marsonya marsonya added the changes required This pull request needs changes label Dec 21, 2020
Copy link
Contributor

@marsonya marsonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good addition to our Codebase.
The doctests are missing though.
The tests can be added later since a lot of other algorithms too don't have tests as of now.

@marsonya marsonya merged commit 3ef27f8 into TheAlgorithms:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required This pull request needs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants