Skip to content

add binary convert #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 31, 2020
Merged

add binary convert #521

merged 9 commits into from
Oct 31, 2020

Conversation

arwysyah
Copy link
Contributor

add convert number to binary number

@arwysyah
Copy link
Contributor Author

sorry i am just new coder, i made many mistakes about code especially on Test,but i try to fix it ,hope you can understand

@itsvinayak
Copy link
Member

itsvinayak commented Oct 31, 2020 •
edited
Loading

hey @arwysyah, sorry for responding so late, you did great work.
please add some documentation(comment and hints) for a better understanding of code and if possible please squash your commits.

looking forward to more PRs

thank you,
@itsvinayak

@itsvinayak itsvinayak added beginner-friendly Easy to implement changes required This pull request needs changes good first issue labels Oct 31, 2020
@arwysyah
Copy link
Contributor Author

Add documentation

@itsvinayak itsvinayak merged commit eab57b8 into TheAlgorithms:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beginner-friendly Easy to implement changes required This pull request needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arwysyah @itsvinayak