Skip to content

Added JSDoc documentation to some sorting functions and added TimoSort #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from Oct 5, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 4, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Documentation change?
    Added Timo Sort.
    Added JSDoc documentation to some sorting algorithms.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #404 .

@ghost ghost mentioned this pull request Oct 4, 2020
Copy link
Member

@itsvinayak itsvinayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are too many changes, please make one file change per commit, read contribution guidelines.
thanks
@itsvinayak

@itsvinayak itsvinayak added the changes required This pull request needs changes label Oct 4, 2020
@ghost
Copy link
Author

ghost commented Oct 4, 2020

Now it's just TimSort algorithm. I changed it. Tommorow I will make a pull request to add JSDoc to all sorting functions.

@ghost ghost requested a review from itsvinayak October 4, 2020 20:42
@itsvinayak itsvinayak merged commit 7e0aff1 into TheAlgorithms:master Oct 5, 2020
mailysantos added a commit to mailysantos/Javascript that referenced this pull request Oct 6, 2020
* Fixes: TheAlgorithms#155  - Check if a string rearranged can be a palindrome (TheAlgorithms#407)

* Check if a string rearranged can be a palindrome

* Fixes: TheAlgorithms#155 - palindromeRearranging

* Update CheckRearrangePalindrome.js

Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* Added Edit Distance Algorithm in Dynamic-Programming (TheAlgorithms#402)

* DP Edit Distance Algorithm

* Update EditDistance.js

Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* 0 1 knapsack (TheAlgorithms#408)

* Added Longest Common Subsequence

* Renamed the File

* Optimized the code

* Optimized the code

* Changed some styles as per the rule

* Again some style fixed

* Added Longest Increasing Subsequence program to the list

* Style changed

* Added 0-1-Knapsack Problem

* Style Changed as per guidelines

* Update ZeroOneKnapsack.js

* Delete LongestCommonSubsequence.js

* Delete LongestIncreasingSubsequence.js

Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* feat: added Polynomial in Maths (TheAlgorithms#397)

* updating DIRECTORY.md

* tweak: must be same output string (TheAlgorithms#395)

* Added tests for Strings algorithms (TheAlgorithms#390)

* test: added tests for check anagram function

* updating DIRECTORY.md

* Added JSDoc documentation to some sorting functions and added TimoSort (TheAlgorithms#406)

* Added TimSort
Co-authored-by: Solot Paul <solotpaul@yahoo.ro>
Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* Fix selection sort and add tests; fixes TheAlgorithms#414 (TheAlgorithms#418)

* Fix selection sort and add tests; fixes TheAlgorithms#414 
Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* Create FibonacciNumber.js (TheAlgorithms#378)

* Create FibonacciNumber.js

* Update FibonacciNumber.js

Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* Added Mean Square Error (TheAlgorithms#417)

* Added Mean Square Error

* Update MeanSquareError.js

Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* Create FibonacciNumberRecursive.js (TheAlgorithms#380)

* Create FibonacciNumberRecursive.js

* Update FibonacciNumberRecursive.js

Co-authored-by: vinayak <itssvinayak@gmail.com>

* updating DIRECTORY.md

* Fix methodname and parameter type in BinaryToDecimal.js (TheAlgorithms#392)

* Update BinaryToDecimal.js

Fix typo in name

* Update BinaryToDecimal.js

Co-authored-by: vinayak <itssvinayak@gmail.com>

* npx fixx (TheAlgorithms#421)

Co-authored-by: vinayak <itssvinayak@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Suhail Malik <suhailmalik8057@gmail.com>
Co-authored-by: Omkarnath Parida <pomkarnath98@gmail.com>
Co-authored-by: Divyajyoti Ukirde <30872426+divyajyotiuk@users.noreply.github.com>
Co-authored-by: balbaal <iqbal.mi20@gmail.com>
Co-authored-by: Alexandre Xavier <ale.bxsantos@gmail.com>
Co-authored-by: DarkWarrior703 <56077342+DarkWarrior703@users.noreply.github.com>
Co-authored-by: Bogdan Lazar <bogdan@bogdanlazar.com>
Co-authored-by: illegalcall <44542765+illegalcall@users.noreply.github.com>
Co-authored-by: Stas <real.peha@gmail.com>
Co-authored-by: Kaustubh Badrike <kaustubh.badrike15@siesgst.ac.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required This pull request needs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant