Skip to content

test: skip test that's running way too long #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2023
Merged

test: skip test that's running way too long #1393

merged 2 commits into from
Oct 2, 2023

Conversation

defaude
Copy link
Contributor

@defaude defaude commented Oct 1, 2023

It's good to have the test there, but there's no use having it running for ~30 minutes or so in the GitHub Action

close #1193

Open in Gitpod know more

Describe your change:

  • [x ] Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

defaude and others added 2 commits October 1, 2023 18:53
It's good to have the test there, but there's no use having it running for ~30 minutes or so in the GitHub Action

close #1193
@raklaptudirm raklaptudirm merged commit 7ff3e5e into TheAlgorithms:master Oct 2, 2023
@defaude defaude deleted the bugfix/1193-long-running-tests branch October 2, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project-Euler/test/Problem044.test.js runs for ~ 17 minutes
3 participants