-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
algorithm: signum #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
algorithm: signum #1266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine; note: this will currently return 1
for NaN; returning NaN would be more sensible IMO.
Oh yes. I completely missed that case. I'm sorry. Thanks for pointing it out, I'll fix it right away. |
You still have an |
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.This PR is to add the implementation of the signum function. TheAlgorithms entry is here