Skip to content

Commit 2513ccd

Browse files
authored
style: include IM_AVERAGE_COMPUTATION_COULD_OVERFLOW (#5131)
1 parent b075c19 commit 2513ccd

File tree

5 files changed

+6
-9
lines changed

5 files changed

+6
-9
lines changed

spotbugs-exclude.xml

-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
<Match>
99
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" />
1010
</Match>
11-
<Match>
12-
<Bug pattern="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW" />
13-
</Match>
1411
<Match>
1512
<Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
1613
</Match>

src/main/java/com/thealgorithms/dynamicprogramming/LongestIncreasingSubsequence.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ private static int binarySearchBetween(int[] t, int end, int key) {
9797
return end + 1;
9898
}
9999
while (left < right - 1) {
100-
int middle = (left + right) / 2;
100+
final int middle = (left + right) >>> 1;
101101
if (t[middle] < key) {
102102
left = middle;
103103
} else {

src/main/java/com/thealgorithms/misc/RangeInSortedArray.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public static void alteredBinSearch(int[] nums, int key, int left, int right, in
2626
if (left > right) {
2727
return;
2828
}
29-
int mid = (left + right) / 2;
29+
int mid = (left + right) >>> 1;
3030
if (nums[mid] > key) {
3131
alteredBinSearch(nums, key, left, mid - 1, range, goLeft);
3232
} else if (nums[mid] < key) {
@@ -52,7 +52,7 @@ public static void alteredBinSearch(int[] nums, int key, int left, int right, in
5252
// of 'key'
5353
public static void alteredBinSearchIter(int[] nums, int key, int left, int right, int[] range, boolean goLeft) {
5454
while (left <= right) {
55-
int mid = (left + right) / 2;
55+
final int mid = (left + right) >>> 1;
5656
if (nums[mid] > key) {
5757
right = mid - 1;
5858
} else if (nums[mid] < key) {
@@ -84,7 +84,7 @@ public static int getCountLessThan(int[] nums, int key) {
8484
public static int getLessThan(int[] nums, int key, int left, int right) {
8585
int count = 0;
8686
while (left <= right) {
87-
int mid = (left + right) / 2;
87+
final int mid = (left + right) >>> 1;
8888
if (nums[mid] > key) {
8989
right = mid - 1;
9090
} else if (nums[mid] <= key) {

src/main/java/com/thealgorithms/sorts/BinaryInsertionSort.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public int[] binaryInsertSort(int[] array) {
1010
int high = i - 1;
1111

1212
while (low <= high) {
13-
int mid = (low + high) / 2;
13+
final int mid = (low + high) >>> 1;
1414
if (temp < array[mid]) {
1515
high = mid - 1;
1616
} else {

src/main/java/com/thealgorithms/sorts/SlowSort.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ private <T extends Comparable<T>> void sort(T[] array, int i, int j) {
1616
if (SortUtils.greaterOrEqual(i, j)) {
1717
return;
1818
}
19-
int m = (i + j) / 2;
19+
final int m = (i + j) >>> 1;
2020
sort(array, i, m);
2121
sort(array, m + 1, j);
2222
if (SortUtils.less(array[j], array[m])) {

0 commit comments

Comments
 (0)