Skip to content

System.Runtime.InteropServices.RuntimeInformation not required for .NET Framework 4.7.1 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flcdrg opened this issue May 28, 2018 · 5 comments

Comments

@flcdrg
Copy link
Contributor

flcdrg commented May 28, 2018

I believe this NuGet package wouldn't be required when targetting 4.7.1 as it it built in

https://docs.microsoft.com/en-au/dotnet/api/system.runtime.interopservices.runtimeinformation?view=netframework-4.7.1

flcdrg added a commit to flcdrg/JavaScriptEngineSwitcher that referenced this issue May 28, 2018
- .NET Framework 4.7.1+ implements System.Runtime.InteropServices.RuntimeInformation so don't need to have dependency on external NuGet package like .NET 4.5

Implements Taritsyn#54
@Taritsyn
Copy link
Owner

Hello, David!

Does dependency on the System.Runtime.InteropServices.RuntimeInformation package lead to any conflicts or errors in your project?

@flcdrg
Copy link
Contributor Author

flcdrg commented May 28, 2018

Yes, you end up with a reference to the assembly, but also a warning that it can't find it (which is a strange warning as the file is sitting there).

image

There's also info logged if you do a command-line build:

Encountered conflict between 'Reference:System.Runtime.InteropServices.RuntimeInformation, Version=4.0.0.0, Culture=n
eutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL' and 'Platform:System.Runtime.InteropServices.Run
timeInformation.dll'. Choosing 'Platform:System.Runtime.InteropServices.RuntimeInformation.dll' because AssemblyVers
ion '4.0.2.0' is greater than '4.0.0.0'.

@Taritsyn
Copy link
Owner

OK. Thanks for information!

@Taritsyn
Copy link
Owner

Hello, David!

This fix was included in version 3.0.0 Beta 4.

@flcdrg
Copy link
Contributor Author

flcdrg commented May 30, 2018

Awesome!

@flcdrg flcdrg closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants