Skip to content

[dotnet] Unify the link .net api docs #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Oct 26, 2024

User description

Description

Changed link to .net api docs to follow the pattern of all other bindings.

Motivation and Context

To be unified.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Updated the .NET API documentation link in the Selenium Clients and WebDriver Language Bindings section to ensure consistency with other language bindings.
  • The new link points to the official Selenium GitHub Pages for .NET API documentation.

Changes walkthrough 📝

Relevant files
Documentation
selenium-clients-and-webdriver-bindings.html
Update .NET API documentation link for consistency             

website_and_docs/layouts/partials/selenium-clients-and-webdriver-bindings.html

  • Updated the .NET API documentation link to a new URL.
  • Ensured consistency with other language bindings documentation links.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Oct 26, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 2cb8b09

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Security
    Add security attribute to external link to prevent potential vulnerabilities

    Consider adding a rel="noopener" attribute to the external link for improved
    security. This prevents the new page from accessing the window.opener property and
    helps protect against potential vulnerabilities.

    website_and_docs/layouts/partials/selenium-clients-and-webdriver-bindings.html [39]

    -<a href="https://seleniumhq.github.io/selenium/docs/api/dotnet/index.html" class="card-link">
    +<a href="https://seleniumhq.github.io/selenium/docs/api/dotnet/index.html" class="card-link" rel="noopener">
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Adding the rel="noopener" attribute is a good security practice for external links, as it prevents the new page from accessing the window.opener property, reducing the risk of certain types of attacks. This suggestion is relevant and improves the security of the code.

    8

    💡 Need additional feedback ? start a PR chat

    @harsha509 harsha509 merged commit 43aa019 into SeleniumHQ:trunk Oct 27, 2024
    3 checks passed
    selenium-ci added a commit that referenced this pull request Oct 27, 2024
    Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 43aa019
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants