Skip to content

Use new dotnet brand #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Use new dotnet brand #1957

merged 3 commits into from
Sep 20, 2024

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Sep 20, 2024

User description

Description

Use .NET instead of C#.

Motivation and Context

Our library is for .NET, not for C# only.

image

(Took from https://github.com/dotnet/brand)

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Updated branding in the documentation to use .NET instead of C#.
  • Changed image sources from csharp.svg to dotnet.svg to reflect the new branding.

Changes walkthrough 📝

Relevant files
Documentation
selenium-clients-and-webdriver-bindings.html
Update branding from C# to .NET in client bindings             

website_and_docs/layouts/partials/selenium-clients-and-webdriver-bindings.html

  • Updated image source from csharp.svg to dotnet.svg.
  • Changed branding to reflect .NET instead of C#.
  • +1/-1     
    selenium-nightly-builds.html
    Update branding from C# to .NET in nightly builds               

    website_and_docs/layouts/partials/selenium-nightly-builds.html

  • Updated image source from csharp.svg to dotnet.svg.
  • Changed branding to reflect .NET instead of C#.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Sep 20, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 97fa743

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 1 labels Sep 20, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Inconsistent Branding
    The image alt text and card title still refer to "C Sharp" instead of ".NET"

    Inconsistent Branding
    The image alt text and card title still refer to "C Sharp" instead of ".NET"

    Copy link
    Contributor

    qodo-merge-pro bot commented Sep 20, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    ✅ Update the image's alt text to match the new branding
    Suggestion Impact:The alt text of the image was updated to include .NET, aligning with the suggestion to reflect the new branding.

    code diff:

    -        <img class="w-100 shadow-1-strong rounded" style="max-width: 100px;" src="/images/programming/dotnet.svg" alt="C Sharp"/>
    +        <img class="w-100 shadow-1-strong rounded" style="max-width: 100px;" src="/images/programming/dotnet.svg" alt=".NET/Csharp"/>

    Update the alt text of the image to reflect the new .NET branding instead of C#.

    website_and_docs/layouts/partials/selenium-clients-and-webdriver-bindings.html [21]

    -<img class="w-100 shadow-1-strong rounded" style="max-width: 100px;" src="/images/programming/dotnet.svg" alt="C Sharp"/>
    +<img class="w-100 shadow-1-strong rounded" style="max-width: 100px;" src="/images/programming/dotnet.svg" alt=".NET"/>
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies an inconsistency in the alt text that should reflect the updated branding to .NET, enhancing accessibility and consistency.

    9
    Consistency
    ✅ Update the displayed language name to match the new branding
    Suggestion Impact:The suggestion impacted the commit by updating the card title to include .NET, although it was combined with C# as .NET/C#.

    code diff:

    -          C#
    +          .NET/C#

    Update the card title to use .NET instead of C# to maintain consistency with the new
    branding.

    website_and_docs/layouts/partials/selenium-clients-and-webdriver-bindings.html [24-25]

     <p class="card-title fw-bold h6">
    -  C#
    +  .NET
     
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion addresses a consistency issue by updating the displayed language name to .NET, aligning with the branding changes made in the PR. This improves clarity and coherence in the documentation.

    9

    💡 Need additional feedback ? start a PR chat

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @nvborisenko !

    @harsha509 harsha509 merged commit 0ed2629 into SeleniumHQ:trunk Sep 20, 2024
    3 checks passed
    selenium-ci added a commit that referenced this pull request Sep 20, 2024
    * Use new dotnet brand
    
    * And even more
    
    * Update selenium-clients-and-webdriver-bindings.html 0ed2629
    @nvborisenko nvborisenko deleted the dotnet-brand branch September 20, 2024 21:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants