-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Use .net 8 SDK to run dotnet examples #1933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
CI build is green, @harsha509 please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nvborisenko !
User description
Description
Selenium supports many many versions. And .net 8 is the first where selenium doesn't require any dependencies.
Motivation and Context
To use the latest stable SDK to run examples.
Types of changes
Checklist
PR Type
enhancement, configuration changes
Description
Changes walkthrough 📝
dotnet-examples.yml
Update .NET SDK version in GitHub Actions workflow
.github/workflows/dotnet-examples.yml
SeleniumDocs.csproj
Upgrade target framework to .NET 8 in project file
examples/dotnet/SeleniumDocs/SeleniumDocs.csproj