-
Notifications
You must be signed in to change notification settings - Fork 393
/
Copy pathUseCompatibleCmdlets.cs
520 lines (471 loc) · 18.3 KB
/
UseCompatibleCmdlets.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
using System;
using System.Collections.Generic;
#if !CORECLR
using System.ComponentModel.Composition;
#endif
using System.Globalization;
using System.IO;
using System.Linq;
using System.Management.Automation.Language;
using System.Text.RegularExpressions;
using Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic;
using Newtonsoft.Json.Linq;
namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
{
/// <summary>
/// UseCompatibleCmdlets: Checks if a script uses Cmdlets compatible with a given version and edition of PowerShell.
/// </summary>
#if !CORECLR
[Export(typeof(IScriptRule))]
#endif
/// <summary>
/// A class to check if a script uses Cmdlets compatible with a given version and edition of PowerShell.
/// </summary>
public class UseCompatibleCmdlets : AstVisitor, IScriptRule
{
private struct RuleParameters
{
public string mode;
public string[] compatibility;
public string reference;
}
private List<DiagnosticRecord> diagnosticRecords;
private Dictionary<string, HashSet<string>> psCmdletMap;
private readonly List<string> validParameters;
private CommandAst curCmdletAst;
private Dictionary<string, bool> curCmdletCompatibilityMap;
private Dictionary<string, dynamic> platformSpecMap;
private string scriptPath;
private bool IsInitialized;
private bool hasInitializationError;
private string reference;
private readonly string defaultReference = "desktop-5.1.14393.206-windows";
private readonly string alternativeDefaultReference = "core-6.1.0-windows";
private RuleParameters ruleParameters;
public UseCompatibleCmdlets()
{
validParameters = new List<string> { "mode", "uri", "compatibility", "reference" };
IsInitialized = false;
}
/// <summary>
/// Retrieves the common name of this rule.
/// </summary>
public string GetCommonName()
{
return string.Format(CultureInfo.CurrentCulture, Strings.UseCompatibleCmdletsCommonName);
}
/// <summary>
/// Retrieves the description of this rule.
/// </summary>
public string GetDescription()
{
return string.Format(CultureInfo.CurrentCulture, Strings.UseCompatibleCmdletsDescription);
}
/// <summary>
/// Retrieves the name of this rule.
/// </summary>
public string GetName()
{
return string.Format(
CultureInfo.CurrentCulture,
Strings.NameSpaceFormat,
GetSourceName(),
Strings.UseCompatibleCmdletsName);
}
/// <summary>
/// Retrieves the severity of the rule: error, warning or information.
/// </summary>
public RuleSeverity GetSeverity()
{
return RuleSeverity.Warning;
}
/// <summary>
/// Gets the severity of the returned diagnostic record: error, warning, or information.
/// </summary>
/// <returns></returns>
public DiagnosticSeverity GetDiagnosticSeverity()
{
return DiagnosticSeverity.Warning;
}
/// <summary>
/// Retrieves the name of the module/assembly the rule is from.
/// </summary>
public string GetSourceName()
{
return string.Format(CultureInfo.CurrentCulture, Strings.SourceName);
}
/// <summary>
/// Retrieves the type of the rule, Builtin, Managed or Module.
/// </summary>
public SourceType GetSourceType()
{
return SourceType.Builtin;
}
/// <summary>
/// Analyzes the given ast to find the [violation]
/// </summary>
/// <param name="ast">AST to be analyzed. This should be non-null</param>
/// <param name="fileName">Name of file that corresponds to the input AST.</param>
/// <returns>A an enumerable type containing the violations</returns>
public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
{
// we do not want to initialize the data structures if the rule is not being used for analysis
// hence we initialize when this method is called for the first time
if (!IsInitialized)
{
Initialize();
}
if (hasInitializationError)
{
yield break;
}
if (ast == null)
{
throw new ArgumentNullException("ast");
}
scriptPath = fileName;
diagnosticRecords.Clear();
ast.Visit(this);
foreach (var dr in diagnosticRecords)
{
yield return dr;
}
}
/// <summary>
/// Visits the CommandAst type node in an AST
/// </summary>
/// <param name="commandAst">CommandAst node</param>
public override AstVisitAction VisitCommand(CommandAst commandAst)
{
if (commandAst == null)
{
return AstVisitAction.SkipChildren;
}
var commandName = commandAst.GetCommandName();
if (commandName == null)
{
return AstVisitAction.SkipChildren;
}
curCmdletAst = commandAst;
ResetCurCmdletCompatibilityMap();
CheckCompatibility();
GenerateDiagnosticRecords();
return AstVisitAction.Continue;
}
/// <summary>
/// Create an instance of DiagnosticRecord and add it to a list
/// </summary>
private void GenerateDiagnosticRecords()
{
bool referenceCompatibility = curCmdletCompatibilityMap[reference];
// If the command is present in reference platform but not in any of the target platforms.
// Or if the command is not present in reference platform but present in any of the target platforms
// then declare it as an incompatible cmdlet.
// If it is present neither in reference platform nor any target platforms, then it is probably a
// non-builtin command and hence do not declare it as an incompatible cmdlet.
// Since we do not check for aliases, the XOR-ing will also make sure that aliases are not flagged
// as they will be found neither in reference platform nor in target platforms
foreach (var platform in ruleParameters.compatibility)
{
var curCmdletCompat = curCmdletCompatibilityMap[platform];
if (!curCmdletCompat && referenceCompatibility)
{
var cmdletName = curCmdletAst.GetCommandName();
var platformInfo = platformSpecMap[platform];
var funcNameTokens = Helper.Instance.Tokens.Where(
token =>
Helper.ContainsExtent(curCmdletAst.Extent, token.Extent)
&& token.Text.Equals(cmdletName));
var funcNameToken = funcNameTokens.FirstOrDefault();
var extent = funcNameToken == null ? null : funcNameToken.Extent;
diagnosticRecords.Add(new DiagnosticRecord(
String.Format(
Strings.UseCompatibleCmdletsError,
cmdletName,
platformInfo.PSEdition,
platformInfo.PSVersion,
platformInfo.OS),
extent,
GetName(),
GetDiagnosticSeverity(),
scriptPath,
null,
null));
}
}
}
/// <summary>
/// Initialize data structures need to check cmdlet compatibility
/// </summary>
private void Initialize()
{
diagnosticRecords = new List<DiagnosticRecord>();
psCmdletMap = new Dictionary<string, HashSet<string>>();
curCmdletCompatibilityMap = new Dictionary<string, bool>(StringComparer.OrdinalIgnoreCase);
platformSpecMap = new Dictionary<string, dynamic>(StringComparer.OrdinalIgnoreCase);
SetupCmdletsDictionary();
IsInitialized = true;
}
/// <summary>
/// Sets up a dictionaries indexed by PowerShell version/edition and OS
/// </summary>
private void SetupCmdletsDictionary()
{
// If the method encounters any error, it returns early
// which implies there is an initialization error
hasInitializationError = true;
Dictionary<string, object> ruleArgs = Helper.Instance.GetRuleArguments(GetName());
if (ruleArgs == null)
{
return;
}
if (!RuleParamsValid(ruleArgs))
{
return;
}
var compatibilityObjectArr = ruleArgs["compatibility"] as object[];
var compatibilityList = new List<string>();
if (compatibilityObjectArr == null)
{
compatibilityList = ruleArgs["compatibility"] as List<string>;
if (compatibilityList == null)
{
return;
}
}
else
{
foreach (var compatItem in compatibilityObjectArr)
{
var compatString = compatItem as string;
if (compatString == null)
{
// ignore (warn) non-string invalid entries
continue;
}
compatibilityList.Add(compatString);
}
}
ruleParameters.compatibility = compatibilityList.ToArray();
reference = defaultReference;
if (compatibilityList.Count == 1 && compatibilityList[0] == defaultReference)
{
reference = alternativeDefaultReference;
}
#if DEBUG
// Setup reference file
object referenceObject;
if (ruleArgs.TryGetValue("reference", out referenceObject))
{
reference = referenceObject as string;
if (reference == null)
{
reference = GetStringArgFromListStringArg(referenceObject);
if (reference == null)
{
return;
}
}
}
#endif
ruleParameters.reference = reference;
// check if the reference file has valid platformSpec
if (!IsValidPlatformString(reference))
{
return;
}
string settingsPath = Settings.GetShippedSettingsDirectory();
#if DEBUG
object modeObject;
if (ruleArgs.TryGetValue("mode", out modeObject))
{
// This is for testing only. User should not be specifying mode!
var mode = GetStringArgFromListStringArg(modeObject);
ruleParameters.mode = mode;
switch (mode)
{
case "offline":
settingsPath = GetStringArgFromListStringArg(ruleArgs["uri"]);
break;
case "online": // not implemented yet.
case null:
default:
return;
}
}
#endif
if (settingsPath == null
|| !ContainsReferenceFile(settingsPath))
{
return;
}
var extentedCompatibilityList = compatibilityList.Union(Enumerable.Repeat(reference, 1));
foreach (var compat in extentedCompatibilityList)
{
string psedition, psversion, os;
// ignore (warn) invalid entries
if (GetVersionInfoFromPlatformString(compat, out psedition, out psversion, out os))
{
platformSpecMap.Add(compat, new { PSEdition = psedition, PSVersion = psversion, OS = os });
curCmdletCompatibilityMap.Add(compat, true);
}
}
ProcessDirectory(
settingsPath,
extentedCompatibilityList);
if (psCmdletMap.Keys.Count != extentedCompatibilityList.Count())
{
return;
}
// reached this point, so no error
hasInitializationError = false;
}
/// <summary>
/// Checks if the given directory has the reference file
/// directory must be non-null
/// </summary>
private bool ContainsReferenceFile(string directory)
{
return File.Exists(Path.Combine(directory, reference + ".json"));
}
/// <summary>
/// Resets the values in curCmdletCompatibilityMap to true
/// </summary>
private void ResetCurCmdletCompatibilityMap()
{
// cannot iterate over collection and change the values, hence the conversion to list
foreach(var key in curCmdletCompatibilityMap.Keys.ToList())
{
curCmdletCompatibilityMap[key] = true;
}
}
private bool IsValidPlatformString(string fileNameWithoutExt)
{
string psedition, psversion, os;
return GetVersionInfoFromPlatformString(
fileNameWithoutExt,
out psedition,
out psversion,
out os);
}
/// <summary>
/// Gets PowerShell Edition, Version and OS from input string
/// </summary>
/// <returns>True if it can retrieve information from string, otherwise, False</returns>
private bool GetVersionInfoFromPlatformString(
string fileName,
out string psedition,
out string psversion,
out string os)
{
psedition = null;
psversion = null;
os = null;
const string pattern = @"^(?<psedition>core|desktop)-(?<psversion>[\S]+)-(?<os>windows|linux|macos)$";
var match = Regex.Match(fileName, pattern, RegexOptions.IgnoreCase);
if (match == Match.Empty)
{
return false;
}
psedition = match.Groups["psedition"].Value;
psversion = match.Groups["psversion"].Value;
os = match.Groups["os"].Value;
return true;
}
/// <summary>
/// Gets the string from a one element string array
/// </summary>
private string GetStringArgFromListStringArg(object arg)
{
if (arg == null)
{
return null;
}
var strList = arg as List<string>;
if (strList == null
|| strList.Count != 1)
{
return null;
}
return strList[0];
}
/// <summary>
/// Search a directory for files of form [PSEdition]-[PSVersion]-[OS].json
/// </summary>
private void ProcessDirectory(string path, IEnumerable<string> acceptablePlatformSpecs)
{
foreach (var filePath in Directory.EnumerateFiles(path))
{
var extension = Path.GetExtension(filePath);
if (String.IsNullOrWhiteSpace(extension)
|| !extension.Equals(".json", StringComparison.OrdinalIgnoreCase))
{
continue;
}
var fileNameWithoutExt = Path.GetFileNameWithoutExtension(filePath);
if (acceptablePlatformSpecs != null
&& !acceptablePlatformSpecs.Contains(fileNameWithoutExt, StringComparer.OrdinalIgnoreCase))
{
continue;
}
psCmdletMap[fileNameWithoutExt] = GetCmdletsFromData(JObject.Parse(File.ReadAllText(filePath)));
}
}
/// <summary>
/// Get a hashset of cmdlet names from a deserialized json file
/// </summary>
/// <param name="deserializedObject"></param>
/// <returns></returns>
private HashSet<string> GetCmdletsFromData(dynamic deserializedObject)
{
var cmdlets = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
dynamic modules = deserializedObject.Modules;
foreach (dynamic module in modules)
{
if (module.ExportedCommands == null)
{
continue;
}
foreach (dynamic cmdlet in module.ExportedCommands)
{
var name = cmdlet.Name as string;
if (name == null)
{
name = cmdlet.Name.ToObject<string>();
}
cmdlets.Add(name);
}
}
return cmdlets;
}
/// <summary>
/// Check if rule arguments are valid
/// </summary>
private bool RuleParamsValid(Dictionary<string, object> ruleArgs)
{
return ruleArgs.Keys.All(
key => validParameters.Any(x => x.Equals(key, StringComparison.OrdinalIgnoreCase)));
}
/// <summary>
/// Check if current command is present in the allowlists
/// If not, flag the corresponding value in curCmdletCompatibilityMap
/// </summary>
private void CheckCompatibility()
{
string commandName = curCmdletAst.GetCommandName();
foreach (var platformSpec in psCmdletMap)
{
if (platformSpec.Value.Contains(commandName))
{
curCmdletCompatibilityMap[platformSpec.Key] = true;
}
else
{
curCmdletCompatibilityMap[platformSpec.Key] = false;
}
}
}
}
}