Virtual debit card #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks 🙏
https://www.github.com/viditvarshney
…On Sat, Sep 1, 2018, 3:19 PM Divyanshu Rawat ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Agk8ZSPZfcfAicK0gIQEvTUWHo0bSay6ks5uWlgbgaJpZM4WVn1n>
.
|
|
@Paarmita |
|
excuse me why my code is not merged yet? |
|
@viditvarshney I have reviewed your code and it looks good to me, but it doesn't mean that it looks good to other contributors and community members as well. @yashovardhanagrawal, can you go through the code and review and see whether it's good to merge. 👍 |
|
Looks good to me too. |
sunilsj99
approved these changes
Sep 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THis is a web based project , this code generates a virtual debit card with name of yours and a CVV number on it ... the best part of this is .. CVV number changes every time when you run the code