Skip to content

No backward compatible changes in Schema are marked as Compatible #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awaqas opened this issue Jan 16, 2024 · 0 comments
Open

No backward compatible changes in Schema are marked as Compatible #611

awaqas opened this issue Jan 16, 2024 · 0 comments
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification
Milestone

Comments

@awaqas
Copy link

awaqas commented Jan 16, 2024

Hello, Thanks alot for this great library. I am testing this library and found the following bugs when comparing Schemas,

Library version: 'org.openapitools.openapidiff:openapi-diff-core:2.1.0-beta.8'

  1. Removing an attribute from a Model is a non-backward compatible change, but It is marked as COMPATIBLE.
  2. Updating description of an attribute is a Metadata change but this is also marked as COMPATIBLE

After several tests, I deduced, The current version is able to detect any change in schema models, but all changes are marked as COMPATIBLE. I think the compatibility checks including metadata change checks are missing.

Please have a look and provide a roadmap when this feature can be fixed. Thanks alot for all the effort and excellent work.

@DrSatyr DrSatyr added the bug label Jan 27, 2025
@DrSatyr DrSatyr removed the bug label Jan 30, 2025
@DrSatyr DrSatyr added the Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification label Apr 5, 2025
@DrSatyr DrSatyr added this to the 2.2.0 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking/Non-Breaking classification Issues related to Breaking/Non-Breaking changes classification
Projects
None yet
Development

No branches or pull requests

2 participants