Skip to content

Commit e0de371

Browse files
authored
Apply suggestions from code review
1 parent 68891bc commit e0de371

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docs/containers/container-build.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ Here are the volumes that are mounted in your container. What you see in your co
258258
For .NET 8, additional mount points at root and for the app user that contain user secrets and the HTTPS certificate might also be present. And in Visual Studio 17.10 preview, the Hot Reload and Token Service volume, along with another component, the Distroless Helper, are combined under a single mount point, `/VSTools`.
259259

260260
> [!NOTE]
261-
> **Visual Studio 17.10 preview** If you're using Docker Engine in Windows Subsystem for Linux (WSL) without Docker Desktop, set the environment variable `VSCT_WslDaemon=1` to have Microsoft Visual Studio use WSL paths when creating volume mounts. The NuGet package [Microsoft.VisualStudio.Azure.Containers.Tools.Targets 1.20.0-Preview 1](https://www.nuget.org/packages/Microsoft.VisualStudio.Azure.Containers.Tools.Targets/1.20.0-Preview.1) is also required.
261+
> **Visual Studio 17.10 preview** If you're using Docker Engine in Windows Subsystem for Linux (WSL) without Docker Desktop, set the environment variable `VSCT_WslDaemon=1` to have Visual Studio use WSL paths when creating volume mounts. The NuGet package [Microsoft.VisualStudio.Azure.Containers.Tools.Targets 1.20.0-Preview 1](https://www.nuget.org/packages/Microsoft.VisualStudio.Azure.Containers.Tools.Targets/1.20.0-Preview.1) is also required.
262262
263263
:::moniker-end
264264

docs/containers/container-launch-settings.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ The following table shows the properties that can be set in this section:
5050
| httpPort | `"httpPort": 24051` | This port on the host is mapped to the container's port 80 when launching the container. |
5151
| launchBrowser | `"launchBrowser": true` | Indicates whether to launch the browser after successfully launching the project. |
5252
| launchBrowserTimeout | `"launchBrowserTimeout": 1` | The maximum amount of time (in seconds) to wait for the app to be ready before launching the browser. |
53-
| launchUrl | `"launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}"` | This URL is used when launching the browser. Supported replacement tokens for this string are: <br/><br/> - `{Scheme}` - Replaced with either "HTTP" or "HTTPS" depending on whether SSL is used. <br/><br/> - `{ServiceHost}` - Usually replaced with "localhost". <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with the container's IP. <br/><br/> - `{ServicePort}` - Usually replaced with either `sslPort` or `httpPort`, depending on whether SSL is used. <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with either `443` or `80`, depending on whether SSL is used. |
53+
| launchUrl | `"launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}"` | This URL is used when launching the browser. Supported replacement tokens for this string are: <br/><br/> - `{Scheme}` - Replaced with either `http` or `https` depending on whether SSL is used. <br/><br/> - `{ServiceHost}` - Usually replaced with "localhost". <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with the container's IP. <br/><br/> - `{ServicePort}` - Usually replaced with either `sslPort` or `httpPort`, depending on whether SSL is used. <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with either `443` or `80`, depending on whether SSL is used. |
5454
| sslPort | `"sslPort": 44381` | This port on the host is mapped to the container's port 443 when launching the container. |
5555
| useSSL | `"useSSL": true` | Indicates whether to use SSL when launching the project. If `useSSL` isn't specified, then SSL is used when `sslPort > 0`. |
5656

0 commit comments

Comments
 (0)