Skip to content

Commit ab24c4d

Browse files
authored
Apply suggestions from code review
1 parent 57b0283 commit ab24c4d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/containers/container-launch-settings.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ The following table shows the properties that can be set in this section:
4545
| Setting name | Example | Description |
4646
| -------------------- | ----------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------- |
4747
| commandLineArgs | `"commandLineArgs": "--mysetting myvalue"` | These command-line arguments for starting your app are used when launching your project in the container. |
48-
|DockerfileRunArguments|`"dockerfileRunArguments": "-l mylabel=value"`|Additional arguments to pass to the [Docker run](https://docs.docker.com/engine/reference/commandline/run/) command.|
48+
|DockerfileRunArguments|`"dockerfileRunArguments": "-l mylabel=value"`|Additional arguments to pass to the [`docker run`](https://docs.docker.com/engine/reference/commandline/run/) command.|
4949
| environmentVariables | `"environmentVariables":` `{`<br/> `"ASPNETCORE_URLS": "https://+:443;http://+:80"``, <br/> `"ASPNETCORE_HTTPS_PORT": "44381"`` <br/> `}` | These environment variable values are passed to the process when it's launched in the container. |
5050
| httpPort | `"httpPort": 24051` | This port on the host is mapped to the container's port 80 when launching the container. |
5151
| launchBrowser | `"launchBrowser": true` | Indicates whether to launch the browser after successfully launching the project. |
@@ -65,12 +65,12 @@ The following table shows the properties that can be set in this section:
6565
| -------------------- | ----------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------- |
6666
| commandLineArgs | `"commandLineArgs": "--mysetting myvalue"` | These command-line arguments for starting your app are used when launching your project in the container. |
6767
| containerRunArguments|`"containerRunArguments": "-l mylabel=value"`|Like `dockerfileRunArguments`, but for use with the .NET SDK container build type. |
68-
|DockerfileRunArguments|`dockerfileRunArguments": "-l mylabel=value"`|Additional arguments to pass to the [Docker run](https://docs.docker.com/engine/reference/commandline/run/) command. <br>/<br/> This setting only applies to projects that use the Dockerfile container build type. <br/><br/> In Visual Studio 17.3 and later, you can use the following replacement tokens added:<br/><br/> - `{ProjectDir}` - Full path to the project directory. <br/><br/> - `{OutDir}` - The value of the MSBuild property OutDir.|
68+
|DockerfileRunArguments|`dockerfileRunArguments": "-l mylabel=value"`|Additional arguments to pass to the [`docker run`](https://docs.docker.com/engine/reference/commandline/run/) command. <br>/<br/> This setting only applies to projects that use the Dockerfile container build type. <br/><br/> In Visual Studio 17.3 and later, you can use the following replacement tokens added:<br/><br/> - `{ProjectDir}` - Full path to the project directory. <br/><br/> - `{OutDir}` - The value of the MSBuild property OutDir.|
6969
| environmentVariables | `"environmentVariables":` {<br/> `"ASPNETCORE_URLS": "https://+:443;http://+:80"`, <br/> `"ASPNETCORE_HTTPS_PORT": "44381"` <br/> } | These environment variable values are passed to the process when it's launched in the container. |
7070
| httpPort | `"httpPort": 24051` | This port on the host is mapped to the container's port 80 when launching the container. |
7171
| launchBrowser | `"launchBrowser": true` | Indicates whether to launch the browser after successfully launching the project. |
7272
| launchBrowserTimeout | `"launchBrowserTimeout": 1` | The maximum amount of time (in seconds) to wait for the app to be ready before launching the browser. |
73-
| launchUrl | `"launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}"` | This URL is used when launching the browser. Supported replacement tokens for this string are: <br/><br/> - `{Scheme}` - Replaced with either "HTTP" or "HTTPS" depending on whether SSL is used. <br/><br/> - `{ServiceHost}` - Usually replaced with "localhost". <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with the container's IP. <br/><br/> - `{ServicePort}` - Usually replaced with either sslPort or httpPort, depending on whether SSL is used. <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with either `443` or `80`, depending on whether SSL is used. |
73+
| launchUrl | `"launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}"` | This URL is used when launching the browser. Supported replacement tokens for this string are: <br/><br/> - `{Scheme}` - Replaced with either `http` or `https`, depending on whether SSL is used. <br/><br/> - `{ServiceHost}` - Usually replaced with "localhost". <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with the container's IP. <br/><br/> - `{ServicePort}` - Usually replaced with either sslPort or httpPort, depending on whether SSL is used. <br/> When you're targeting Windows containers on Windows 10 RS3 or older, though, it's replaced with either `443` or `80`, depending on whether SSL is used. |
7474
| publishAllPorts | `"publishAllPorts": true` | If true, pass `-P` to `docker run`, which publishes all exposed ports to a random port. See [Docker documentation](https://docs.docker.com/engine/reference/commandline/run/). However, when you specify `sslPort`, Visual Studio still passes `-p 5002:443`, so your service should still be listening on port 5002.|
7575
| sslPort | `"sslPort": 44381` | This port on the host is mapped to the container's port 443 when launching the container. |
7676
| useSSL | `"useSSL": true` | Indicates whether to use SSL when launching the project. If `useSSL` isn't specified, then SSL is used when `sslPort > 0`. |

0 commit comments

Comments
 (0)