Update azure-sqldb.md

Make Powershell script parameters consistent, Cleanup

Author: geekfog

docs/pipelines/targets/azure-sqldb.md

@@ -76,11 +76,11 @@ The following PowerShell script creates firewall rules. You can check in this sc
 param
 (
   [String] [Parameter(Mandatory = $true)] $ServerName,
-  [String] [Parameter(Mandatory = $true)] $ResourceGroup,
-  [String] $AzureFirewallName = "AzureWebAppFirewall"
+  [String] [Parameter(Mandatory = $true)] $ResourceGroupName,
+  [String] $FirewallRuleName = "AzureWebAppFirewall"
 )
 $agentIP = (New-Object net.webclient).downloadstring("https://api.ipify.org")
-New-AzSqlServerFirewallRule -ResourceGroupName $ResourceGroup -ServerName $ServerName -FirewallRuleName $AzureFirewallName -StartIPAddress $agentIp -EndIPAddress $agentIP
+New-AzSqlServerFirewallRule -ResourceGroupName $ResourceGroupName -ServerName $ServerName -FirewallRuleName $FirewallRuleName -StartIPAddress $agentIp -EndIPAddress $agentIP
 ```
 
 ### Classic
@@ -91,25 +91,26 @@ param
 (
   [String] [Parameter(Mandatory = $true)] $ServerName,
   [String] [Parameter(Mandatory = $true)] $ResourceGroupName,
-  [String] $AzureFirewallName = "AzureWebAppFirewall"
+  [String] $FirewallRuleName = "AzureWebAppFirewall"
 )
 
 $ErrorActionPreference = 'Stop'
 
-function New-AzureSQLServerFirewallRule {
+Function New-AzureSQLServerFirewallRule {
   $agentIP = (New-Object net.webclient).downloadstring("https://api.ipify.org")
-  New-AzureSqlDatabaseServerFirewallRule -StartIPAddress $agentIp -EndIPAddress $agentIp -FirewallRuleName $AzureFirewallName -ServerName $ServerName -ResourceGroupName $ResourceGroupName
+  New-AzureSqlDatabaseServerFirewallRule -StartIPAddress $agentIp -EndIPAddress $agentIp -FirewallRuleName $FirewallRuleName -ServerName $ServerName -ResourceGroupName $ResourceGroupName
 }
-function Update-AzureSQLServerFirewallRule{
+
+Function Update-AzureSQLServerFirewallRule{
   $agentIP= (New-Object net.webclient).downloadstring("https://api.ipify.org")
-  Set-AzureSqlDatabaseServerFirewallRule -StartIPAddress $agentIp -EndIPAddress $agentIp -FirewallRuleName $AzureFirewallName -ServerName $ServerName -ResourceGroupName $ResourceGroupName
+  Set-AzureSqlDatabaseServerFirewallRule -StartIPAddress $agentIp -EndIPAddress $agentIp -FirewallRuleName $FirewallRuleName -ServerName $ServerName -ResourceGroupName $ResourceGroupName
 }
 
-If ((Get-AzureSqlDatabaseServerFirewallRule -ServerName $ServerName -FirewallRuleName $AzureFirewallName -ResourceGroupName $ResourceGroupName -ErrorAction SilentlyContinue) -eq $null)
+If ((Get-AzureSqlDatabaseServerFirewallRule -ServerName $ServerName -FirewallRuleName $FirewallRuleName -ResourceGroupName $ResourceGroupName -ErrorAction SilentlyContinue) -eq $null)
 {
   New-AzureSQLServerFirewallRule
 }
-else
+Else
 {
   Update-AzureSQLServerFirewallRule
 }
@@ -124,10 +125,10 @@ The following PowerShell script removes firewall rules. You can check-in this sc
 param
 (
   [String] [Parameter(Mandatory = $true)] $ServerName,
-  [String] [Parameter(Mandatory = $true)] $ResourceGroup,
-  [String] $AzureFirewallName = "AzureWebAppFirewall"
+  [String] [Parameter(Mandatory = $true)] $ResourceGroupName,
+  [String] $FirewallRuleName = "AzureWebAppFirewall"
 )
-Remove-AzSqlServerFirewallRule -ServerName $ServerName -FirewallRuleName $AzureFirewallName -ResourceGroupName $ResourceGroup
+Remove-AzSqlServerFirewallRule -ServerName $ServerName -FirewallRuleName $FirewallRuleName -ResourceGroupName $ResourceGroupName
 ```
 
 ### Classic
@@ -138,14 +139,14 @@ param
 (
   [String] [Parameter(Mandatory = $true)] $ServerName,
   [String] [Parameter(Mandatory = $true)] $ResourceGroupName,
-  [String] $AzureFirewallName = "AzureWebAppFirewall"
+  [String] $FirewallRuleName = "AzureWebAppFirewall"
 )
 
 $ErrorActionPreference = 'Stop'
 
-If ((Get-AzureSqlDatabaseServerFirewallRule -ServerName $ServerName -FirewallRuleName $AzureFirewallName -ResourceGroupName $ResourceGroupName -ErrorAction SilentlyContinue))
+If ((Get-AzureSqlDatabaseServerFirewallRule -ServerName $ServerName -FirewallRuleName $FirewallRuleName -ResourceGroupName $ResourceGroupName -ErrorAction SilentlyContinue))
 {
-  Remove-AzureSqlDatabaseServerFirewallRule -FirewallRuleName $AzureFirewallName -ServerName $ServerName -ResourceGroupName $ResourceGroupName
+  Remove-AzureSqlDatabaseServerFirewallRule -FirewallRuleName $FirewallRuleName -ServerName $ServerName -ResourceGroupName $ResourceGroupName
 }
 ```