Skip to content

Prompt the users to select endpoint before sign in #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lujiangping-synyi opened this issue May 29, 2019 · 3 comments
Open

Prompt the users to select endpoint before sign in #334

lujiangping-synyi opened this issue May 29, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@lujiangping-synyi
Copy link

🐛 Bug Report

When user only register in the leetcode-cn, vs code plug-in of leetcode's default endpoint is leetc-de-com, and just return "invalid password?"

To Reproduce

install the leetcode plug-in
register a new account only in leetcode-cn: https://leetcode-cn.com
Click the Sign in to LeetCode in vs code

Expected behavior

Solution 1: Should return clearly information to user for current login endpoint and not register
message

Solution 2: Before user login into the leetcode, should let user choose the endpoint first

Extension Output

[ERROR] You are not login yet?
login: login: pass: - Signing in leetcode.com
[ERROR] invalid password?

Your Environment

  • os: windows 10
  • extension settings: no
  • nodejs version: v10.15.3
  • vscode version: 1.34.0
  • extension version: [0.14.3]
@lujiangping-synyi lujiangping-synyi changed the title If I only register the account in leetcode-cn, and will login failed when login in vs code Add endpoint options before sign in or move the Switch Endpoint before the Sign In/Out in Details May 29, 2019
@jdneo
Copy link
Member

jdneo commented May 29, 2019

Hi @lujiangping-synyi,

Thank you for your feedback. Unfortunately, the LeetCode does not share the accounts with LeetCode-CN. We have related docs to hint user about this: https://github.com/jdneo/vscode-leetcode/wiki/Troubleshooting#thinking-cannot-sign-in

Regarding your solutions,

  1. I think it's hard to achieve because as of the extension, it's impossible to know whether the login failure is caused by wrong password or wrong endpoint.

  2. This is a good suggestion. I'll think about it later.

@jdneo jdneo changed the title Add endpoint options before sign in or move the Switch Endpoint before the Sign In/Out in Details Prompt the users to select endpoint before sign in May 29, 2019
@lujiangping-synyi
Copy link
Author

Great, Thank you for taking my suggestion

@jdneo
Copy link
Member

jdneo commented Jun 8, 2019

@lujiangping-synyi Let's just leave it open because I want to see if there are more users have the same requirement for this.

@jdneo jdneo reopened this Jun 8, 2019
@jdneo jdneo added the enhancement New feature or request label Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants