-
Notifications
You must be signed in to change notification settings - Fork 665
🙋🙋🙋Survey: location to show the webview #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
help wanted
Extra attention is needed
Comments
Just use current implementation without any changeClick 👍 if you vote for this |
Always show in
|
Always show in
|
Always fetch the setting
|
Each webview has its own setting to determine the locationClick 👍 if you vote for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today, the extension has three kinds of webviews which are:
Preview
,Top Voted Solution
&Result
. Each of them has its own logic to show in some certain places:Preview
: Determined by the settingleetcode.enableSideMode
Solution
: Get the location ofPreview
page. If there's no openedPreview
page, it will show in theColumn One
Result
: Always inColumn Two
Here are some proposals for improvement:
Column One
Column Two
leetcode.enableSideMode
before showing for all the three webviewsPlease let us know which one you are preferred. You can directly add the 👍 in the following choices.
Thank you for your patience.
The text was updated successfully, but these errors were encountered: