Skip to content

🙋🙋🙋Survey: location to show the webview #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdneo opened this issue May 9, 2019 · 6 comments
Open

🙋🙋🙋Survey: location to show the webview #315

jdneo opened this issue May 9, 2019 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@jdneo
Copy link
Member

jdneo commented May 9, 2019

Today, the extension has three kinds of webviews which are: Preview, Top Voted Solution & Result. Each of them has its own logic to show in some certain places:

  • Preview: Determined by the setting leetcode.enableSideMode
  • Solution: Get the location of Preview page. If there's no opened Preview page, it will show in the Column One
  • Result: Always in Column Two

Here are some proposals for improvement:

  • Just use current implementation without any change
  • Always show in Column One
  • Always show in Column Two
  • Always fetch the setting leetcode.enableSideMode before showing for all the three webviews
  • Each webview has its own setting to determine the location

Please let us know which one you are preferred. You can directly add the 👍 in the following choices.

Thank you for your patience.

@jdneo
Copy link
Member Author

jdneo commented May 9, 2019

Just use current implementation without any change

Click 👍 if you vote for this

@jdneo
Copy link
Member Author

jdneo commented May 9, 2019

Always show in Column One

Click 👍 if you vote for this

@jdneo
Copy link
Member Author

jdneo commented May 9, 2019

Always show in Column Two

Click 👍 if you vote for this

@jdneo
Copy link
Member Author

jdneo commented May 9, 2019

Always fetch the setting leetcode.enableSideMode before showing for all the three webviews

Click 👍 if you vote for this

@jdneo
Copy link
Member Author

jdneo commented May 9, 2019

Each webview has its own setting to determine the location

Click 👍 if you vote for this

@jdneo jdneo pinned this issue May 9, 2019
@jdneo jdneo added the help wanted Extra attention is needed label May 9, 2019
@jdneo jdneo changed the title Survey: location to show the webview 🙋🙋🙋Survey: location to show the webview May 9, 2019
@ueoo
Copy link

ueoo commented Jun 19, 2019

I want this, just like the web leetcode.
Thanks a lot!
Screen Shot 2019-06-19 at 15 46 01

@jdneo jdneo unpinned this issue Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants