Skip to content

Store problems cache in treeview #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Vigilans opened this issue Apr 29, 2019 · 1 comment · Fixed by #301
Closed

Store problems cache in treeview #299

Vigilans opened this issue Apr 29, 2019 · 1 comment · Fixed by #301
Labels
engineering
Milestone
0.14.2

Comments

@Vigilans
Copy link
Contributor

🚀 Feature Proposal

TreeviewProvider should hold the ownership of all problems, and expose an interface to retrieve a problem by its id.
@jdneo
Copy link
Member

jdneo commented Apr 29, 2019

I would suggest that we extract this as a new component to cache the problem metadata. Since it seems that we have other components that may leverage this cache.

@jdneo jdneo added the enhancement New feature or request label Apr 29, 2019
@jdneo jdneo added this to the 0.14.2 milestone Apr 29, 2019
@jdneo jdneo mentioned this issue Apr 30, 2019
Merged
@jdneo jdneo added engineering and removed enhancement New feature or request labels Apr 30, 2019
@jdneo jdneo closed this as completed in #301 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering
Projects
None yet
Milestone
0.14.2
Development

Successfully merging a pull request may close this issue.

refactor: Extract explorer cache related code LeetCode-OpenSource/vscode-leetcode
2 participants
@jdneo @Vigilans