Skip to content

Let font size of problem describe file equal to editor.fontSize not workbench font size. #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roachsinai opened this issue Mar 30, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@roachsinai
Copy link

🚀 Feature Proposal

Let font size of problem describe file equal to editor.fontSize not workbench font size.

Motivation

The font size of problem describe file is to small.

image

As it opening in editor section why the font size not equal editor font size?

image

@jdneo jdneo added the bug Something isn't working label Mar 31, 2019
@Vigilans Vigilans self-assigned this Apr 2, 2019
@jdneo jdneo added this to the 0.13.3 milestone Apr 2, 2019
@Vigilans
Copy link
Contributor

Vigilans commented Apr 2, 2019

The preview, solution and result webview will use built-in markdown engine's css file to render. So the best choice would be to use markdown.preview.fontSize.

However, I tested on my vscode and found that the setting wouldn't change the font size in the webview. It is because that I didn't ship the extra contribution logic from the original extension. I will work on this lately.

@roachsinai
Copy link
Author

Thanks!

@Vigilans Vigilans added enhancement New feature or request and removed bug Something isn't working labels Apr 3, 2019
@jdneo jdneo modified the milestones: 0.13.3, 0.13.4 Apr 4, 2019
@jdneo jdneo closed this as completed in #260 Apr 8, 2019
@Vigilans
Copy link
Contributor

14.0 is now updated.

@roachsinai
Copy link
Author

Seems the font of markdown still smaller than editor font size.

image

@jdneo
Copy link
Member

jdneo commented Apr 23, 2019

@roachsinai Did you update the setting: markdown.preview.fontSize?

@roachsinai
Copy link
Author

@jdneo No, I didn't. Now, it workded, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants