Skip to content

Fix CI redux #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jan 14, 2018
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
cacbbe4
ignore gems
ianfixes Jan 10, 2018
8d41392
address security concerns from github regarding gem versions
ianfixes Jan 10, 2018
ab47c85
split some files and add installer functionality
ianfixes Jan 10, 2018
d736446
don't disable the display if previously enabled outside with_display
ianfixes Jan 10, 2018
effc510
fix path for OSX
ianfixes Jan 10, 2018
64e272d
add test for the board-is-installed function
ianfixes Jan 10, 2018
341034d
add CI script to gem
ianfixes Jan 10, 2018
2119ebc
wrap 'which' method in its own class and add tests
ianfixes Jan 11, 2018
a247e2d
be more verbose about skipping display manager enable
ianfixes Jan 11, 2018
a115466
fix logic in existing_display?
ianfixes Jan 11, 2018
49c42ff
use IO.popen instead of forking a fork
ianfixes Jan 11, 2018
6d38e66
add environment to run command
ianfixes Jan 11, 2018
7f6b216
quote the string
ianfixes Jan 11, 2018
71c1d3f
use builtin ruby to save development time
ianfixes Jan 11, 2018
a1c6386
log all parameters in arduino_cmd run
ianfixes Jan 11, 2018
c0c3ce3
test output of xdpyinfo
ianfixes Jan 11, 2018
7119806
expose ability to run commands in display environment
ianfixes Jan 11, 2018
7740d57
wrap the display manager command runner
ianfixes Jan 11, 2018
6d6b084
query x server to wait for launch
ianfixes Jan 11, 2018
7e58049
Add some doc comments
ianfixes Jan 11, 2018
c3237b0
hail mary logging
ianfixes Jan 11, 2018
dc2b35f
add ability to capture preferences
ianfixes Jan 12, 2018
fdeda7f
guess when graphical error message prevents command from completing
ianfixes Jan 12, 2018
110daa1
mute a lot of logging
ianfixes Jan 12, 2018
8fc631c
factor gui guessing into its own function
ianfixes Jan 12, 2018
e8a7610
add ability to set prefs
ianfixes Jan 12, 2018
a76f074
board_installed? use run_with_gui_guess
ianfixes Jan 12, 2018
a4f3ce3
add commands to install boards and libraries
ianfixes Jan 12, 2018
8b26d2a
suppress arduino output
ianfixes Jan 12, 2018
135f374
prefs can fail graphically, so handle them graphically
ianfixes Jan 13, 2018
78fca73
expose kwargs explicitly in run call
ianfixes Jan 13, 2018
6124d6a
make debug messages in display_manager toggleable
ianfixes Jan 13, 2018
87fb012
add run wrapper that does not capture, but with the same signture as …
ianfixes Jan 13, 2018
fb38943
add more to test script, get closer to install.sh parity
ianfixes Jan 13, 2018
d2d77b5
use null file instead of IO.pipe. not sure why this matters for success
ianfixes Jan 13, 2018
64b0886
allow switching to a particular board for compilation
ianfixes Jan 14, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add run wrapper that does not capture, but with the same signture as …
…run_with_capture
  • Loading branch information
ianfixes committed Jan 13, 2018
commit 87fb012643852661716e81ccb2d8b3ebbf274669
9 changes: 8 additions & 1 deletion lib/arduino_ci/arduino_cmd.rb
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def run_with_gui_guess(message, *args, **kwargs)
end

# run a command and capture its output
# @return [Hash] {:out => StringIO, :err => StringIO, :success => bool}
# @return [Hash] {:out => String, :err => String, :success => bool}
def run_and_capture(*args, **kwargs)
pipe_out, pipe_out_wr = IO.pipe
pipe_err, pipe_err_wr = IO.pipe
Expand All @@ -99,6 +99,13 @@ def run_and_capture(*args, **kwargs)
{ out: str_out, err: str_err, success: success }
end

# run a command and don't capture its output, but use the same signature
# @return [Hash] {:out => String, :err => String, :success => bool}
def run_wrap(*args, **kwargs)
success = run(*args, **kwargs)
{ out: "NOPE, use run_and_capture", err: "NOPE, use run_and_capture", success: success }
end

# check whether a board is installed
# we do this by just selecting a board.
# the arduino binary will error if unrecognized and do a successful no-op if it's installed
Expand Down