Skip to content

Don't define ostream& operator() if already defined by Apple #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2020

Conversation

jgfoster
Copy link
Member

@jgfoster jgfoster commented Oct 5, 2020

Possible fix for #170. I'm not sure when Xcode started providing this, but it feels recent and this change allows tests to pass for me on my local build. I've tried to make it safe for everyone else.

@ianfixes
Copy link
Collaborator

ianfixes commented Oct 5, 2020

This seems like the right approach for now, can you just note it in CHANGELOG.md and then I'll merge?

@ianfixes ianfixes merged commit 9df75db into Arduino-CI:master Oct 5, 2020
@ianfixes
Copy link
Collaborator

ianfixes commented Oct 5, 2020

Are you blocked until a new gem is released with this fix?

@jgfoster
Copy link
Member Author

jgfoster commented Oct 5, 2020

I don't think so. I haven't seen this in my external library development, only when I'm testing arduino_ci itself (through SampleProjects/TestSomething). So I can continue my separate development in the old gem and my internal development in the (newly-merged) master. At least that is the way it seems to me at the moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants