Skip to content

Best practices to exclude folders from compilation? #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianfixes opened this issue Apr 3, 2018 · 4 comments · Fixed by #134
Closed

Best practices to exclude folders from compilation? #29

ianfixes opened this issue Apr 3, 2018 · 4 comments · Fixed by #134
Labels
enhancement New feature or request question Further information is requested unittest libs The assert / assure / unittest reporting apparatus is affected

Comments

@ianfixes
Copy link
Collaborator

ianfixes commented Apr 3, 2018

Issue / Feature Request Summary

A configuration parameter to exclude folders from compilation.

Consider a case where all libraries are in ./lib so they can all be in a single git hub repo (using git submodules). arduino_ci walks the tree to find all the header files - irrespective of any compiler directives to use mock headers/classes instead, the libraries get pulled in too (which may break compilation).

@ianfixes ianfixes added enhancement New feature or request question Further information is requested unittest libs The assert / assure / unittest reporting apparatus is affected labels Apr 3, 2018
@dolfandringa
Copy link
Contributor

dolfandringa commented Jul 27, 2019

I would really love to have this feature. Issue #69 could have been easily fixed with this feature (just add .bundle to the ignore path) but I am combining arduino_ci with https://github.com/ladislas/Bare-Arduino-Project which both fill part of my use-case, but neither fill both. Right now the Bare-Arduino-Project makefiles are adding files to my repos, that cause arduino_ci tests to fail because arduino_ci is including those files in the build process. They are temporary files that I don't need, so manually removing them before running tests fixes the problem. But I wish I could just ignore the respective folders instead.

@ianfixes
Copy link
Collaborator Author

arduino_ci is meant to test standalone libraries, not bundled libraries (i.e., it expects to run from the root of an Arduino library). This is an interesting use case though. I assume that you could simply change the working directory to the library you wanted to test, and then run the script. Do you have code up that shows the failure?

@dolfandringa
Copy link
Contributor

dolfandringa commented Jul 29, 2019

@ianfixes I currently made it work from the root directory, when adding the linked PR. A demo version can be found on https://github.com/dolfandringa/Bare-Arduino-Project It combines arduino_ci with Arduino-Makefile. The root Makefile isn't fully functional yet, but the scripts in scripts/ are.

@ianfixes
Copy link
Collaborator Author

What does your bare arduino project do if there are multiple libraries in the lib directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested unittest libs The assert / assure / unittest reporting apparatus is affected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants