From 1980d3585e3c7fce74b811ca8d77733036cae76c Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 3 Apr 2023 07:13:52 +0200 Subject: [PATCH] pg_basebackup: Correct type of WalSegSz The pg_basebackup code had WalSegSz as uint32, whereas the rest of the code has it as int. This seems confusing, and using the extra range wouldn't actually work. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/1bf15c7a-0acd-1864-081e-7a28814310fe%40enterprisedb.com --- src/bin/pg_basebackup/streamutil.c | 2 +- src/bin/pg_basebackup/streamutil.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c index e7618f46172..15514599c4e 100644 --- a/src/bin/pg_basebackup/streamutil.c +++ b/src/bin/pg_basebackup/streamutil.c @@ -31,7 +31,7 @@ #define ERRCODE_DUPLICATE_OBJECT "42710" -uint32 WalSegSz; +int WalSegSz; static bool RetrieveDataDirCreatePerm(PGconn *conn); diff --git a/src/bin/pg_basebackup/streamutil.h b/src/bin/pg_basebackup/streamutil.h index 04ceb309719..268c163213c 100644 --- a/src/bin/pg_basebackup/streamutil.h +++ b/src/bin/pg_basebackup/streamutil.h @@ -24,7 +24,7 @@ extern char *dbuser; extern char *dbport; extern char *dbname; extern int dbgetpassword; -extern uint32 WalSegSz; +extern int WalSegSz; /* Connection kept global so we can disconnect easily */ extern PGconn *conn; -- 2.30.2