pg_logicalinspect: Fix possible crash when passing a directory path.
authorMasahiko Sawada <msawada@postgresql.org>
Tue, 11 Mar 2025 16:56:40 +0000 (09:56 -0700)
committerMasahiko Sawada <msawada@postgresql.org>
Tue, 11 Mar 2025 16:56:40 +0000 (09:56 -0700)
commitbd65cb3cd48a7a5ce48b26f8031ad3968efed87e
treefd6ae91a937707f9ab4adefb93ea1cd3a940e4da
parenta49927f04cd0c66e1bc41f551160fce50f382d8c
pg_logicalinspect: Fix possible crash when passing a directory path.

Previously, pg_logicalinspect functions were too trusting of their
input and blindly passed it to SnapBuildRestoreSnapshot(). If the
input pointed to a directory, the server could a PANIC error while
attempting to fsync_fname() with isdir=false on a directory.

This commit adds validation checks for input filenames and passes the
LSN extracted from the filename to SnapBuildRestoreSnapshot() instead
of the filename itself. It also adds regression tests for various
input patterns and permission checks.

Bug: #18828
Reported-by: Robins Tharakan <tharakan@gmail.com>
Co-authored-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Co-authored-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/18828-0f4701c635064211@postgresql.org
contrib/pg_logicalinspect/Makefile
contrib/pg_logicalinspect/expected/pg_logicalinspect.out [new file with mode: 0644]
contrib/pg_logicalinspect/pg_logicalinspect.c
contrib/pg_logicalinspect/sql/pg_logicalinspect.sql [new file with mode: 0644]
src/backend/replication/logical/snapbuild.c
src/include/replication/snapbuild_internal.h