Remove server support for old BASE_BACKUP command syntax.
authorRobert Haas <rhaas@postgresql.org>
Tue, 8 Feb 2022 15:53:59 +0000 (10:53 -0500)
committerRobert Haas <rhaas@postgresql.org>
Thu, 10 Feb 2022 15:48:33 +0000 (10:48 -0500)
commit9cd28c2e5f11dfeef64a14035b82e70acead65fd
tree6f130ed5fa33f4de47fc65c1f8c1ff724a1e6c4f
parent6d503d2a47324c15c5b4274bf4dd016064143754
Remove server support for old BASE_BACKUP command syntax.

Commit 0ba281cb4bf9f5f65529dfa4c8282abb734dd454 added a new syntax
for the BASE_BACKUP command, with extensible options, but maintained
support for the legacy syntax. This isn't important for PostgreSQL,
where pg_basebackup works with older server versions but not newer
ones, but it could in theory matter for out-of-core users of the
replication protocol.

Discussion on pgsql-hackers, however, suggests that no one is aware
of any out-of-core use of the BASE_BACKUP command, and the consensus
is in favor of removing support for the old syntax to simplify the
code, so do that.

Discussion: http://postgr.es/m/CA+TgmoazKcKUWtqVa0xZqSzbKgTH+X-aw4V7GyLD68EpDLMh8A@mail.gmail.com
doc/src/sgml/protocol.sgml
src/backend/replication/repl_gram.y
src/backend/replication/repl_scanner.l