Fixup various StringInfo function usages
authorDavid Rowley <drowley@postgresql.org>
Tue, 9 Apr 2024 23:53:32 +0000 (11:53 +1200)
committerDavid Rowley <drowley@postgresql.org>
Tue, 9 Apr 2024 23:53:32 +0000 (11:53 +1200)
commit8461424fd717877ead0706984ef9b6440b2a97ad
treeac5ee13afb549d4f44830d8ac6d08d846e1c1b74
parentff9f72c68f678ded340b431c3e280fe56644a3e7
Fixup various StringInfo function usages

This adjusts various appendStringInfo* function calls to use a more
appropriate and efficient function with the same behavior.  For example,
use appendStringInfoChar() when appending a single character rather than
appendStringInfo() and appendStringInfoString() when no formatting is
required rather than using appendStringInfo().

All adjustments made here are in code that's new to v17, so it makes
sense to fix these now rather than wait a few years and make
backpatching harder.

Discussion: https://postgr.es/m/CAApHDvojY2UvMiO+9_55ArTj10P1LBNJyyoGB+C65BLDNT0GsQ@mail.gmail.com
Reviewed-by: Nathan Bossart, Tom Lane
contrib/postgres_fdw/deparse.c
src/backend/replication/logical/slotsync.c
src/backend/replication/logical/tablesync.c
src/backend/utils/adt/ri_triggers.c
src/backend/utils/adt/ruleutils.c