TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 19 Jan 2022 21:29:09 +0000 (16:29 -0500)
commit6c4a8903b93fa5ee088a282b2e8b79ad6571a853
tree935c43c36f8ed1a75cfe085c67844b6f11b65c8d
parentf201da39edcd6ac1ab9a3edf3e20e2a73bbbe69e
TAP tests: check for postpid anyway when "pg_ctl start" fails.

"pg_ctl start" might start a new postmaster and then return failure
anyway, for example if PGCTLTIMEOUT is exceeded.  If there is a
postmaster there, it's still incumbent on us to shut it down at
script end, so check for the PID file even though we are about
to fail.

This has been broken all along, so back-patch to all supported branches.

Discussion: https://postgr.es/m/647439.1642622744@sss.pgh.pa.us
src/test/perl/PostgreSQL/Test/Cluster.pm