Make attstattarget nullable
authorPeter Eisentraut <peter@eisentraut.org>
Sat, 13 Jan 2024 17:14:53 +0000 (18:14 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Sat, 13 Jan 2024 17:14:53 +0000 (18:14 +0100)
commit4f622503d6de975ac87448aea5cea7de4bc140d5
treec09756e667e5150678e8ebf9aee6c1cd5e376a96
parent45da69371ebfc4d6982695e58791989660c1cc33
Make attstattarget nullable

This changes the pg_attribute field attstattarget into a nullable
field in the variable-length part of the row.  If no value is set by
the user for attstattarget, it is now null instead of previously -1.
This saves space in pg_attribute and tuple descriptors for most
practical scenarios.  (ATTRIBUTE_FIXED_PART_SIZE is reduced from 108
to 104.)  Also, null is the semantically more correct value.

The ANALYZE code internally continues to represent the default
statistics target by -1, so that that code can avoid having to deal
with null values.  But that is now contained to the ANALYZE code.
Only the DDL code deals with attstattarget possibly null.

For system columns, the field is now always null.  The ANALYZE code
skips system columns anyway.

To set a column's statistics target to the default value, the new
command form ALTER TABLE ... SET STATISTICS DEFAULT can be used.  (SET
STATISTICS -1 still works.)

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/4da8d211-d54d-44b9-9847-f2a9f1184c76@eisentraut.org
16 files changed:
doc/src/sgml/ref/alter_table.sgml
src/backend/access/common/tupdesc.c
src/backend/bootstrap/bootstrap.c
src/backend/catalog/genbki.pl
src/backend/catalog/heap.c
src/backend/catalog/index.c
src/backend/commands/analyze.c
src/backend/commands/tablecmds.c
src/backend/parser/gram.y
src/backend/utils/cache/lsyscache.c
src/bin/pg_dump/pg_dump.c
src/include/catalog/catversion.h
src/include/catalog/pg_attribute.h
src/include/commands/vacuum.h
src/include/utils/lsyscache.h
src/test/regress/expected/create_index.out