Improve error messages about mismatching relkind
authorPeter Eisentraut <peter@eisentraut.org>
Thu, 8 Jul 2021 07:38:52 +0000 (09:38 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Thu, 8 Jul 2021 07:44:51 +0000 (09:44 +0200)
commit2ed532ee8c474e9767e76e1f3251cc3a0224358c
tree3365ea8086789ae6b1b0ddf3a3edd16459075a7d
parentb9734c13f168ef0d487aa122e486ca9b6dd6aa59
Improve error messages about mismatching relkind

Most error messages about a relkind that was not supported or
appropriate for the command was of the pattern

    "relation \"%s\" is not a table, foreign table, or materialized view"

This style can become verbose and tedious to maintain.  Moreover, it's
not very helpful: If I'm trying to create a comment on a TOAST table,
which is not supported, then the information that I could have created
a comment on a materialized view is pointless.

Instead, write the primary error message shorter and saying more
directly that what was attempted is not possible.  Then, in the detail
message, explain that the operation is not supported for the relkind
the object was.  To simplify that, add a new function
errdetail_relkind_not_supported() that does this.

In passing, make use of RELKIND_HAS_STORAGE() where appropriate,
instead of listing out the relkinds individually.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/dc35a398-37d0-75ce-07ea-1dd71d98f8ec@2ndquadrant.com
32 files changed:
contrib/amcheck/expected/check_heap.out
contrib/amcheck/verify_heapam.c
contrib/pageinspect/expected/page.out
contrib/pageinspect/rawpage.c
contrib/pg_surgery/expected/heap_surgery.out
contrib/pg_surgery/heap_surgery.c
contrib/pg_visibility/expected/pg_visibility.out
contrib/pg_visibility/pg_visibility.c
contrib/pgstattuple/expected/pgstattuple.out
contrib/pgstattuple/pgstatapprox.c
contrib/pgstattuple/pgstatindex.c
contrib/pgstattuple/pgstattuple.c
src/backend/catalog/Makefile
src/backend/catalog/pg_class.c [new file with mode: 0644]
src/backend/catalog/toasting.c
src/backend/commands/comment.c
src/backend/commands/indexcmds.c
src/backend/commands/lockcmds.c
src/backend/commands/seclabel.c
src/backend/commands/sequence.c
src/backend/commands/statscmds.c
src/backend/commands/tablecmds.c
src/backend/commands/trigger.c
src/backend/parser/parse_utilcmd.c
src/backend/rewrite/rewriteDefine.c
src/include/catalog/pg_class.h
src/test/regress/expected/alter_table.out
src/test/regress/expected/create_table_like.out
src/test/regress/expected/foreign_data.out
src/test/regress/expected/indexing.out
src/test/regress/expected/sequence.out
src/test/regress/expected/stats_ext.out