Fix search_path to a safe value during maintenance operations.
authorJeff Davis <jdavis@postgresql.org>
Tue, 5 Mar 2024 01:31:38 +0000 (17:31 -0800)
committerJeff Davis <jdavis@postgresql.org>
Tue, 5 Mar 2024 01:31:38 +0000 (17:31 -0800)
commit2af07e2f749a9208ca1ed84fa1d8fe0e75833288
tree94ba59cc859b1f22dbd0ee85b9062e757f50d65e
parent2c29e7fc95b24f5ccfec0d2db458d2130606f446
Fix search_path to a safe value during maintenance operations.

While executing maintenance operations (ANALYZE, CLUSTER, REFRESH
MATERIALIZED VIEW, REINDEX, or VACUUM), set search_path to
'pg_catalog, pg_temp' to prevent inconsistent behavior.

Functions that are used for functional indexes, in index expressions,
or in materialized views and depend on a different search path must be
declared with CREATE FUNCTION ... SET search_path='...'.

This change was previously committed as 05e1737351, then reverted in
commit 2fcc7ee7af because it was too late in the cycle.

Preparation for the MAINTAIN privilege, which was previously reverted
due to search_path manipulation hazards.

Discussion: https://postgr.es/m/d4ccaf3658cb3c281ec88c851a09733cd9482f22.camel@j-davis.com
Discussion: https://postgr.es/m/E1q7j7Y-000z1H-Hr%40gemulon.postgresql.org
Discussion: https://postgr.es/m/e44327179e5c9015c8dda67351c04da552066017.camel%40j-davis.com
Reviewed-by: Greg Stark, Nathan Bossart, Noah Misch
30 files changed:
contrib/amcheck/t/004_verify_nbtree_unique.pl
contrib/amcheck/verify_nbtree.c
doc/src/sgml/amcheck.sgml
doc/src/sgml/brin.sgml
doc/src/sgml/ref/analyze.sgml
doc/src/sgml/ref/cluster.sgml
doc/src/sgml/ref/create_index.sgml
doc/src/sgml/ref/refresh_materialized_view.sgml
doc/src/sgml/ref/reindex.sgml
doc/src/sgml/ref/vacuum.sgml
src/backend/access/brin/brin.c
src/backend/catalog/index.c
src/backend/catalog/namespace.c
src/backend/commands/analyze.c
src/backend/commands/cluster.c
src/backend/commands/indexcmds.c
src/backend/commands/matview.c
src/backend/commands/vacuum.c
src/bin/scripts/t/100_vacuumdb.pl
src/include/utils/guc.h
src/test/modules/test_oat_hooks/expected/alter_table.out
src/test/modules/test_oat_hooks/expected/test_oat_hooks.out
src/test/regress/expected/matview.out
src/test/regress/expected/namespace.out
src/test/regress/expected/privileges.out
src/test/regress/expected/vacuum.out
src/test/regress/sql/matview.sql
src/test/regress/sql/namespace.sql
src/test/regress/sql/privileges.sql
src/test/regress/sql/vacuum.sql