For inplace update, send nontransactional invalidations.
authorNoah Misch <noah@leadboat.com>
Fri, 25 Oct 2024 13:51:02 +0000 (06:51 -0700)
committerNoah Misch <noah@leadboat.com>
Fri, 25 Oct 2024 13:51:02 +0000 (06:51 -0700)
commit243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704
treed092b3c3b261da64a5f17a35b87d67626f9591f7
parent0fe173680e148984a150326b80c322a91ffa899d
For inplace update, send nontransactional invalidations.

The inplace update survives ROLLBACK.  The inval didn't, so another
backend's DDL could then update the row without incorporating the
inplace update.  In the test this fixes, a mix of CREATE INDEX and ALTER
TABLE resulted in a table with an index, yet relhasindex=f.  That is a
source of index corruption.  Back-patch to v12 (all supported versions).
The back branch versions don't change WAL, because those branches just
added end-of-recovery SIResetAll().  All branches change the ABI of
extern function PrepareToInvalidateCacheTuple().  No PGXN extension
calls that, and there's no apparent use case in extensions.

Reviewed by Nitin Motiani and (in earlier versions) Andres Freund.

Discussion: https://postgr.es/m/20240523000548.58.nmisch@google.com
19 files changed:
src/backend/access/heap/heapam.c
src/backend/access/heap/heapam_xlog.c
src/backend/access/rmgrdesc/heapdesc.c
src/backend/access/rmgrdesc/standbydesc.c
src/backend/access/transam/xact.c
src/backend/catalog/index.c
src/backend/commands/event_trigger.c
src/backend/replication/logical/decode.c
src/backend/utils/cache/catcache.c
src/backend/utils/cache/inval.c
src/backend/utils/cache/syscache.c
src/include/access/heapam_xlog.h
src/include/access/xlog_internal.h
src/include/storage/sinval.h
src/include/utils/catcache.h
src/include/utils/inval.h
src/test/isolation/expected/inplace-inval.out
src/test/isolation/specs/inplace-inval.spec
src/tools/pgindent/typedefs.list