Fix ALTER DEFAULT PRIVILEGES with duplicated objects
authorMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:38:17 +0000 (11:38 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:38:17 +0000 (11:38 +0900)
commit21378e1fefedcaed3d855ae7aa772555295d05d6
tree4f0ec9d79e48fd219636c80ea32b252d795cb5aa
parenta0efda88a679edaee9855628cb05b2ab00d80a15
Fix ALTER DEFAULT PRIVILEGES with duplicated objects

Specifying duplicated objects in this command would lead to unique
constraint violations in pg_default_acl or "tuple already updated by
self" errors.  Similarly to GRANT/REVOKE, increment the command ID after
each subcommand processing to allow this case to work transparently.

A regression test is added by tweaking one of the existing queries of
privileges.sql to stress this case.

Reported-by: Andrus
Author: Michael Paquier
Reviewed-by: Álvaro Herrera
Discussion: https://postgr.es/m/ae2a7dc1-9d71-8cba-3bb9-e4cb7eb1f44e@hot.ee
Backpatch-through: 9.5
src/backend/catalog/aclchk.c
src/test/regress/expected/privileges.out
src/test/regress/sql/privileges.sql