From: Peter Geoghegan <pg@bowt.ie>
Date: Mon, 29 Apr 2019 21:14:38 +0000 (-0700)
Subject: Remove obsolete _bt_insert_parent() comment.
X-Git-Tag: REL_12_BETA1~154
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=9ee7414ed0435d8946d040eb523824f2d71e2418;p=postgresql.git

Remove obsolete _bt_insert_parent() comment.

Remove a comment that refers to a coding practice that was fully removed
by commit a8b8f4db, which introduced MarkBufferDirty().  It looks like
the comment was even obsolete before then, since it concerns
write-ordering dependencies with synchronous buffer writes.
---

diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
index 49a94d8cd9b..9c82ca6597f 100644
--- a/src/backend/access/nbtree/nbtinsert.c
+++ b/src/backend/access/nbtree/nbtinsert.c
@@ -1786,7 +1786,6 @@ _bt_insert_parent(Relation rel,
 		 */
 		_bt_relbuf(rel, rbuf);
 
-		/* Check for error only after writing children */
 		if (pbuf == InvalidBuffer)
 			elog(ERROR, "failed to re-find parent key in index \"%s\" for split pages %u/%u",
 				 RelationGetRelationName(rel), bknum, rbknum);