Remove CustomPath's TextOutCustomPath method.

You can't really do anything useful with this in the form it currently
exists; among other problems, there's no way to reread whatever
information might be produced when the path is output.  Work is
underway to replace this with a more useful and more general system of
extensible nodes, but let's start by getting rid of this bit.

Extracted from a larger patch by KaiGai Kohei.

diff --git a/doc/src/sgml/custom-scan.sgml b/doc/src/sgml/custom-scan.sgml
index 5bba1256d3199f01be999da4fff74eda6d56bba2..9a8d092decc9dcbb8d20f4b7d5b2c2f1a672c4d8 100644 (file)
--- a/doc/src/sgml/custom-scan.sgml
+++ b/doc/src/sgml/custom-scan.sgml
@@ -125,19 +125,6 @@ Plan *(*PlanCustomPath) (PlannerInfo *root,
     be a <literal>CustomScan</> object, which the callback must allocate and
     initialize.  See <xref linkend="custom-scan-plan"> for more details.
    </para>
-
-   <para>
-<programlisting>
-void (*TextOutCustomPath) (StringInfo str,
-                           const CustomPath *node);
-</programlisting>
-    Generate additional output when <function>nodeToString</> is invoked on
-    this custom path.  This callback is optional.  Since
-    <function>nodeToString</> will automatically dump all fields in the
-    structure that it can see, including <structfield>custom_private</>, this
-    is only useful if the <structname>CustomPath</> is actually embedded in a
-    larger struct containing additional fields.
-   </para>
   </sect2>
  </sect1>
 

diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index b487c002a8cea249f94c75bcf3e586a8075728c3..d59b95465431cc41cc8492fdbdbacd05a041bf6e 100644 (file)
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -1705,8 +1705,6 @@ _outCustomPath(StringInfo str, const CustomPath *node)
    WRITE_NODE_FIELD(custom_private);
    appendStringInfoString(str, " :methods ");
    _outToken(str, node->methods->CustomName);
-   if (node->methods->TextOutCustomPath)
-       node->methods->TextOutCustomPath(str, node);
 }
 
 static void

diff --git a/src/include/nodes/relation.h b/src/include/nodes/relation.h
index 94925984bf2d8dd17e3228a2d5c2ab2de9c139e2..595438cb24dfb99ea264df10fa4136441c485933 100644 (file)
--- a/src/include/nodes/relation.h
+++ b/src/include/nodes/relation.h
@@ -958,9 +958,6 @@ typedef struct CustomPathMethods
                                                List *tlist,
                                                List *clauses,
                                                List *custom_plans);
-   /* Optional: print additional fields besides "private" */
-   void        (*TextOutCustomPath) (StringInfo str,
-                                             const struct CustomPath *node);
 } CustomPathMethods;
 
 typedef struct CustomPath