Don't allow relminmxid to go backwards during VACUUM FULL
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 27 Jun 2014 18:43:45 +0000 (14:43 -0400)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 27 Jun 2014 18:43:45 +0000 (14:43 -0400)
We were allowing a table's pg_class.relminmxid value to move backwards
when heaps were swapped by VACUUM FULL or CLUSTER.  There is a
similar protection against relfrozenxid going backwards, which we
neglected to clone when the multixact stuff was rejiggered by commit
0ac5ad5134f276.

Backpatch to 9.3, where relminmxid was introduced.

As reported by Heikki in
http://www.postgresql.org/message-id/52401AEA.9000608@vmware.com

src/backend/commands/cluster.c

index 6f87170946c21c5a409785d6533c919d83083dec..46b41c17d21f2078f39fdb7346144a62d3c4a8b1 100644 (file)
@@ -873,6 +873,12 @@ copy_heap_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex,
    if (TransactionIdPrecedes(FreezeXid, OldHeap->rd_rel->relfrozenxid))
        FreezeXid = OldHeap->rd_rel->relfrozenxid;
 
+   /*
+    * MultiXactCutoff, similarly, shouldn't go backwards either.
+    */
+   if (MultiXactIdPrecedes(MultiXactCutoff, OldHeap->rd_rel->relminmxid))
+       MultiXactCutoff = OldHeap->rd_rel->relminmxid;
+
    /* return selected values to caller */
    *pFreezeXid = FreezeXid;
    *pCutoffMulti = MultiXactCutoff;