Fix possible corruption of AfterTriggerEventLists in subtransaction rollback.

afterTriggerInvokeEvents failed to adjust events->tailfree when truncating
the last chunk of an event list.  This could result in the data being
"de-truncated" by afterTriggerRestoreEventList during a subsequent
subtransaction abort.  Even that wouldn't kill us, because the re-added data
would just be events marked DONE --- unless the data had been partially
overwritten by new events.  Then we might crash, or in any case misbehave
(perhaps fire triggers twice, or fire triggers with the wrong event data).
Per bug #5622 from Thue Janus Kristensen.

Back-patch to 8.4 where the current trigger list representation was introduced.

diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
index 900626aa455ec8db382c75d05022c06bdd043807..b69687615e9ba7fa234616026b43abceb704f2c4 100644 (file)
--- a/src/backend/commands/trigger.c
+++ b/src/backend/commands/trigger.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *   $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.264 2010/08/05 15:25:35 rhaas Exp $
+ *   $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.265 2010/08/19 15:46:18 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2955,6 +2955,7 @@ afterTriggerAddEvent(AfterTriggerEventList *events,
        else
            events->tail->next = chunk;
        events->tail = chunk;
+       /* events->tailfree is now out of sync, but we'll fix it below */
    }
 
    /*
@@ -3356,6 +3357,15 @@ afterTriggerInvokeEvents(AfterTriggerEventList *events,
        {
            chunk->freeptr = CHUNK_DATA_START(chunk);
            chunk->endfree = chunk->endptr;
+
+           /*
+            * If it's last chunk, must sync event list's tailfree too.  Note
+            * that delete_ok must NOT be passed as true if there could be
+            * stacked AfterTriggerEventList values pointing at this event
+            * list, since we'd fail to fix their copies of tailfree.
+            */
+           if (chunk == events->tail)
+               events->tailfree = chunk->freeptr;
        }
    }