Remove useless const qualifier

Claiming that the typevar argument to DefineCompositeType() is const
was a plain lie.  A similar case in DefineVirtualRelation() was
already changed in passing in commit 1575fbcb.  Also clean up the now
unnecessary casts that used to cast away the const.

diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c
index 3523554cfbdef6f27c5f43b380b821ad8f34cd0c..22c1132e9b9cab513345accdc1cce256dbfd6b3e 100644 (file)
--- a/src/backend/commands/typecmds.c
+++ b/src/backend/commands/typecmds.c
@@ -1980,7 +1980,7 @@ AssignTypeArrayOid(void)
  *-------------------------------------------------------------------
  */
 Oid
-DefineCompositeType(const RangeVar *typevar, List *coldeflist)
+DefineCompositeType(RangeVar *typevar, List *coldeflist)
 {
    CreateStmt *createStmt = makeNode(CreateStmt);
    Oid         old_type_oid;
@@ -1991,7 +1991,7 @@ DefineCompositeType(const RangeVar *typevar, List *coldeflist)
     * now set the parameters for keys/inheritance etc. All of these are
     * uninteresting for composite types...
     */
-   createStmt->relation = (RangeVar *) typevar;
+   createStmt->relation = typevar;
    createStmt->tableElts = coldeflist;
    createStmt->inhRelations = NIL;
    createStmt->constraints = NIL;

diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c
index f895488a5a5715ad5962adc44781a9768a3f918c..99fb7dbb8f4d0aa2dd6e10883cbfb1cc9b333c53 100644 (file)
--- a/src/backend/commands/view.c
+++ b/src/backend/commands/view.c
@@ -254,7 +254,7 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace,
         * now set the parameters for keys/inheritance etc. All of these are
         * uninteresting for views...
         */
-       createStmt->relation = (RangeVar *) relation;
+       createStmt->relation = relation;
        createStmt->tableElts = attrList;
        createStmt->inhRelations = NIL;
        createStmt->constraints = NIL;

diff --git a/src/include/commands/typecmds.h b/src/include/commands/typecmds.h
index 9de5330924e6a8b8d2fafe8560a3a4557c821617..0c7e10d392d372d91498176df6517bfd20abe51c 100644 (file)
--- a/src/include/commands/typecmds.h
+++ b/src/include/commands/typecmds.h
@@ -25,7 +25,7 @@ extern void DefineDomain(CreateDomainStmt *stmt);
 extern void DefineEnum(CreateEnumStmt *stmt);
 extern void DefineRange(CreateRangeStmt *stmt);
 extern void AlterEnum(AlterEnumStmt *stmt);
-extern Oid DefineCompositeType(const RangeVar *typevar, List *coldeflist);
+extern Oid DefineCompositeType(RangeVar *typevar, List *coldeflist);
 extern Oid AssignTypeArrayOid(void);
 
 extern void AlterDomainDefault(List *names, Node *defaultRaw);