Rename removable xid function for consistency.

GlobalVisIsRemovableFullXid() is now GlobalVisCheckRemovableFullXid().
This is consistent with the general convention for FullTransactionId
equivalents of functions that deal with TransactionId values.  It now
matches the nearby GlobalVisCheckRemovableXid() function, which performs
the same check for callers that use TransactionId values.

Oversight in commit dc7420c2c92.

Discussion: https://postgr.es/m/CAH2-Wzmes12jFNDcVgpU89Vp=r6uLFrE-MT0fjSWGsE70UiNaA@mail.gmail.com

diff --git a/src/backend/access/gist/gistutil.c b/src/backend/access/gist/gistutil.c
index cf53dad4743722b3a41c0d345b100d748956454e..a3ec9f2cfe4249d7e80ffcbc91d840a2f316b9bb 100644 (file)
--- a/src/backend/access/gist/gistutil.c
+++ b/src/backend/access/gist/gistutil.c
@@ -914,7 +914,7 @@ gistPageRecyclable(Page page)
         */
        FullTransactionId deletexid_full = GistPageGetDeleteXid(page);
 
-       return GlobalVisIsRemovableFullXid(NULL, deletexid_full);
+       return GlobalVisCheckRemovableFullXid(NULL, deletexid_full);
    }
    return false;
 }

diff --git a/src/backend/access/gist/gistxlog.c b/src/backend/access/gist/gistxlog.c
index c1d4b5d4f232117fa9d7565a65829a09a8aeb373..f2eda79bc1ab95df5bd8fcd0ad7f2b2cd4bd3fdd 100644 (file)
--- a/src/backend/access/gist/gistxlog.c
+++ b/src/backend/access/gist/gistxlog.c
@@ -388,7 +388,7 @@ gistRedoPageReuse(XLogReaderState *record)
     * pages in the index via the FSM.  That's all they do though.
     *
     * latestRemovedXid was the page's deleteXid.  The
-    * GlobalVisIsRemovableFullXid(deleteXid) test in gistPageRecyclable()
+    * GlobalVisCheckRemovableFullXid(deleteXid) test in gistPageRecyclable()
     * conceptually mirrors the PGPROC->xmin > limitXmin test in
     * GetConflictingVirtualXIDs().  Consequently, one XID value achieves the
     * same exclusion effect on primary and standby.

diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index cf12eda5041139ebd6a0c5cb8863ff45513c4d91..4085891237a70972521a241408795a95c793e150 100644 (file)
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -4146,7 +4146,7 @@ GlobalVisTestNonRemovableHorizon(GlobalVisState *state)
  * GlobalVisTestIsRemovableFullXid(), see their comments.
  */
 bool
-GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid)
+GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid)
 {
    GlobalVisState *state;
 

diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h
index c21ee3c289c967b5e2cdf4e9d99d26b4be6d07cf..2c8b881a09daedbcd77f7475cf6a263eea296dce 100644 (file)
--- a/src/include/utils/snapmgr.h
+++ b/src/include/utils/snapmgr.h
@@ -155,7 +155,7 @@ extern bool GlobalVisTestIsRemovableFullXid(GlobalVisState *state, FullTransacti
 extern FullTransactionId GlobalVisTestNonRemovableFullHorizon(GlobalVisState *state);
 extern TransactionId GlobalVisTestNonRemovableHorizon(GlobalVisState *state);
 extern bool GlobalVisCheckRemovableXid(Relation rel, TransactionId xid);
-extern bool GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid);
+extern bool GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid);
 
 /*
  * Utility functions for implementing visibility routines in table AMs.